413014 - Garburator fails on nsNSSIOLayer.ii

Status: RESOLVED INVALID

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Benjamin Smedberg]

Garburator fails on nsNSSIOLayer.ii with the following exception:

terminate called after throwing an instance of 'std::out_of_range'
  what():  basic_string::substr

I am positive that my sources are perfectly up to date.

ccparse works without error on the same file. I've attached the file, but I'm not sure how much good that will do without my full objdir.

Comment 1

[David Mandelin [:dmandelin]]

With some help from Taras, I managed to prove that the .ii file itself has bad macro location annotations, almost certainly due to a bug in MCPP. 

Is your MCPP up to date? Kiyoshi put out a new version fairly recently. MCPP processed this file correctly in the build I use for analysis, so if you're version isn't the latest (rev 86, released 12/30), I'm guessing that's it.

I don't know how much you've updated MCPP, so I just want to mention a gotcha in the upgrade process. With the gcc integration build, you need to 'make uninstall' the old version first thing, before you update your sources or rebuild. Otherwise you'll have a hard time installing the new version.

If by some chance updating MCPP doesn't fix it, please give me the command line make used to build this file on your machine, and then I'll test it more/debug MCPP/notify Kiyoshi.

Comment 2

[Benjamin Smedberg]

I had an old-ish MCPP... I just updated it to revision 87, uninstall/reinstall, and I'm still experiencing this error...

The command is

/builds/gcc-3.4.6-installed/bin/g++34 -m32 -save-temps -Wp,-W0,-K -o nsCertTree.o -c  -DNSS_ENABLE_ECC -DMOZILLA_INTERNAL_API -DOSTYPE=\"Linux2.6.23.1-21\" -DOSARCH=Linux -I../../../../dist/include/nss -I../../../../dist/include/nspr -I../../../../dist/include/xpcom -I../../../../dist/include/string -I../../../../dist/include/necko -I../../../../dist/include/uriloader -I../../../../dist/include/pref -I../../../../dist/include/docshell -I../../../../dist/include/caps -I../../../../dist/include/dom -I../../../../dist/include/intl -I../../../../dist/include/locale -I../../../../dist/include/profile -I../../../../dist/include/windowwatcher -I../../../../dist/include/js -I../../../../dist/include/widget -I../../../../dist/include/layout -I../../../../dist/include/content -I../../../../dist/include/xpconnect -I../../../../dist/include/unicharutil -I../../../../dist/include/pipboot -I../../../../dist/include   -I../../../../dist/include/pipnss -I../../../../dist/include/nspr     -I../../../../js/tamarin -I../../../../../src/js/tamarin/MMgc -I../../../../dist/sdk/include    -fPIC  -DNS_DISABLE_LITERAL_TEMPLATE  -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread  -DDEBUG -D_DEBUG -DDEBUG_bsmedberg -DTRACING -g -fno-inline  -DNS_DISABLE_LITERAL_TEMPLATE  -DMOZILLA_CLIENT -include ../../../../mozilla-config.h -Wp,-MD,.deps/nsCertTree.pp ../../../../../src/security/manager/ssl/src/nsCertTree.cpp

Which macro is being annotated incorrectly? Perhaps I can try to make a reduced testcase.

Comment 3

[David Mandelin [:dmandelin]]

The bad macro is the one on line 109 of nsNSSIOLayer.cpp. I'm also trying to build a reduced test case.

Comment 4

[David Mandelin [:dmandelin]]

Is your new MCPP installed properly? I had it print the version by adding -v to the command line (a modified version of your command above--see ~dmandelin/junk/cmd), and I get this: 

MCPP V.2.7-prerelease (2007/10) for GCC compiled by GCC V.3.4

On dm-oink01:

MCPP V.2.7-prerelease (2007/12) for GCC compiled by GCC V.3.4

Comment 5

[Benjamin Smedberg]

Yeah :-(

I forgot to override program_transform_name when doing "make install" for MCPP, which means it was installing i686-pc-linux-mcpp instead of mcpp. Duh.