413016 - "ASSERTION: SVG frame expected" with svg:after in SVG document

Status: RESOLVED WORKSFORME

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase

This is similar to bug 409461.  I think the main difference is that the <svg> element here is the document root rather than being inside an HTML document.

Comment 1

[Boris Zbarsky [:bzbarsky]]

nsCSSFrameConstructor::ConstructDocElementFrame needs to not allow before/after content in the SVG case.

Comment 2

[Robert Longson [:longsonr]]

Attachment: patch

FWIW,although there are other calls to ProcessChildren it doesn't look as if SVG content ought to be able to get there and if it does it should be patched in some other way, avoiding the code path altogether.

Comment 3

[Robert Longson [:longsonr]]

Checked in, then backed out. Possibly caused problems on qm-mini-ubuntu05.

Comment 4

[Jonathan Watt [:jwatt]]

Was this bug the cause Robert? Should we re-request approval for it?

Comment 5

[Robert Longson [:longsonr]]

I could try checking it in again. It was one of 2 check ins at the time.

Comment 6

[Jonathan Watt [:jwatt]]

You could try it on the try server first: http://wiki.mozilla.org/Build:TryServer

Comment 7

[Mike Schroepfer]

Comment on attachment 297928 [details] [diff] [review]
patch

Removing approval since this missed the 1.9 cutoff.

Comment 8

[Reed Loden [:reed]]

Robert, time to land this on Hg?

Comment 9

[Robert Longson [:longsonr]]

IMHO it needs a green tree to land and a reasonable chance of not getting subsequent spurious oranges. Seems difficult currently. Feel free to land it if you wish and you get to it before I do but be prepared to back it out again if necessary.

Comment 10

[Jesse Ruderman]

This bug is now WFM, but I don't think longsonr's patch has been checked in...

Comment 11

[Robert Longson [:longsonr]]

Fixed by 473390 if not before.