Closed
Bug 413081
Opened 17 years ago
Closed 17 years ago
Delete the icon cache directory if the cache index is damaged
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.6
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
Details
(Keywords: fixed1.8.1.12)
Attachments
(1 file)
|
1.04 KB,
patch
|
mark
:
superreview+
|
Details | Diff | Splinter Review |
Back when I was actively looking at the cache code, I noticed that if the cache file were damaged we'd leave a bunch of inaccessible cache files lying around forever. This will remove the folder if the file is unreadable, so we can start fresh.
(I had intended to make this part of a larger set of changes to the cache, but I'm not sure when I'll get back to that, and I'd like to get this out of my tree.)
Attachment #297915 -
Flags: superreview?(mark)
Comment 1•17 years ago
|
||
Comment on attachment 297915 [details] [diff] [review]
fix
This patch is good, but the bug should say something about "icon cache" in the title.
This might suck if the user has lots of crap in the icon cache directory (bug 388649), but it shouldn't happen often, 388649 will slowly clean up people's cache directories, and 388649 is in 1.5.4, so...OK.
Attachment #297915 -
Flags: superreview?(mark) → superreview+
| Assignee | ||
Updated•17 years ago
|
Summary: Delete the cache directory if the cache index is damaged → Delete the icon cache directory if the cache index is damaged
| Assignee | ||
Comment 2•17 years ago
|
||
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: fixed1.8.1.12
Resolution: --- → FIXED
Target Milestone: --- → Camino1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•