413089 - Search bar does not work on SpreadFirefox homepage

Status: VERIFIED FIXED

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[Paul Kim]

[Bug] Search bar does not work on SpreadFirefox homepage
Posted January 18th, 2008 by jglassenberg

When entering a search term in the Search bar on the right-panel of the SpreadFirefox homepage, hitting search just sends me to the main search page. No search results appear, and I have to re-enter the search term on the results page to perform this search.

Comment 1

[Paul Booker]

Looking into this now ...

Comment 2

[Paul Booker]

Would you please commit the changes to search/search.module
(Committed revision 9714.)


There was a problem with the core module search . I needed to take out the line   ..
$form['#action'] = url('search/node');

from the method search_box(). If we have no further problems with search ill request this changes be patched against the drupal core 


function search_box($form_id) {
  // Use search_keys instead of keys to avoid ID conflicts with the search block.
  $form[$form_id .'_keys'] = array(
    '#type' => 'textfield',
    '#size' => 15,
    '#default_value' => '',
    '#attributes' => array('title' => t('Enter the terms you wish to search for.')),
  );
  $form['submit'] = array('#type' => 'submit', '#value' => t('Search'));
  // Always go to the search page since the search form is not guaranteed to be
  // on every page.
  $form['#action'] = url('search/node');
  $form['#base'] = 'search_box_form';

  return $form;
}

Comment 3

[Paul Booker]

Sorry , hold commiting i have broken something.

Comment 4

[Paul Booker]

Sorry for the delay here guys. 

The problem i was seeing was only in my localhost drupal cache as was quickly
verified by looking at the sandbox on mozilla.com .

Would you please push through the change

Thanks
Paul

Comment 5

[Justin Fitzhugh]

review from webdev and approval from pkim/marketing still needed for push.

Comment 6

[Michael Morgan [:morgamic]]

Paul can you post the actual diff as an attachment to this bug?  Code in bugzilla comments is hard to read.

Comment 7

[Paul Booker]

You can see the patch here ..
http://viewvc.svn.mozilla.org/vc/projects/spreadfirefox.com/trunk/modules/search/search.module?r1=5872&r2=9714&view=patch

but here it is ..

--- projects/spreadfirefox.com/trunk/modules/search/search.module	2007/08/14 21:48:18	5872
+++ projects/spreadfirefox.com/trunk/modules/search/search.module	2008/01/21 14:35:13	9714
@@ -1045,7 +1045,7 @@
   $form['submit'] = array('#type' => 'submit', '#value' => t('Search'));
   // Always go to the search page since the search form is not guaranteed to be
   // on every page.
-  $form['#action'] = url('search/node');
+  //$form['#action'] = url('search/node');
   $form['#base'] = 'search_box_form';
 
   return $form;

Comment 8

[Paul Booker]

Attachment: search.module patch

and as an attachment

Comment 9

[Michael Morgan [:morgamic]]

Posting in the bug as an attachment (and in diff format) makes it easier for reviewing.  Thanks.  a=morgamic.

Comment 10

[matthew zeier [:mrz]]

[root@mradm01 www.spreadfirefox.com]# svn up
U    modules/sfx/sfx_affiliates/sfx_affiliates.module
U    modules/search/search.module
Updated to revision 9753.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

http://www.spreadfirefox.com/search/node/download