Closed
Bug 413094
Opened 18 years ago
Closed 18 years ago
FUEL Application registers unnecessary observers
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3 beta3
People
(Reporter: ehsan.akhgari, Assigned: mfinkle)
References
()
Details
Attachments
(1 file, 1 obsolete file)
1.81 KB,
patch
|
Gavin
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
The quite-application and quit-application-granted observers are unnecessarily registered by FUEL Application class. These observers can be removed. This change should also affect bug 407963, which is trying to move this code too toolkit.
Reporter | ||
Updated•18 years ago
|
Target Milestone: Firefox 3 → Firefox 3 M11
Assignee | ||
Comment 1•18 years ago
|
||
Simply removes 2 lines that "addOberver" unused notifications
Assignee: nobody → mark.finkle
Status: NEW → ASSIGNED
Attachment #298206 -
Flags: review?(gavin.sharp)
Updated•18 years ago
|
Attachment #298206 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Updated•18 years ago
|
Attachment #298206 -
Flags: approval1.9?
Reporter | ||
Comment 2•18 years ago
|
||
Comment on attachment 298206 [details] [diff] [review]
Remove use of unneeded notifications
The patch should remove the removeObserver calls as well.
Please check the URL again: <http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/fuel/src/fuelApplication.js&rev=1.24&mark=1160,1161,1226,1227#1145>
Attachment #298206 -
Flags: review-
Attachment #298206 -
Flags: review+
Attachment #298206 -
Flags: approval1.9?
Assignee | ||
Comment 3•18 years ago
|
||
This removes both observer parts for the unneeded notifications. Thanks Ehsan.
Attachment #298206 -
Attachment is obsolete: true
Attachment #298249 -
Flags: review?(gavin.sharp)
Comment 4•18 years ago
|
||
Comment on attachment 298249 [details] [diff] [review]
Removes the "addObserver" & removeObserver" calls for unneeded notifcations
I coulda sworn I saw these in the original patch!
Attachment #298249 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Updated•18 years ago
|
Attachment #298249 -
Flags: approval1.9?
Updated•18 years ago
|
Attachment #298249 -
Flags: approval1.9? → approval1.9+
Updated•18 years ago
|
Keywords: checkin-needed
Comment 5•18 years ago
|
||
Checking in browser/fuel/src/fuelApplication.js;
/cvsroot/mozilla/browser/fuel/src/fuelApplication.js,v <-- fuelApplication.js
new revision: 1.25; previous revision: 1.24
done
You need to log in
before you can comment on or make changes to this bug.
Description
•