413128 - All calendars are deselected after Lightning update

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Sebastian Schwieger]

After Lightning update all calendars are deselected. This happens when updating from a build prior to 20080106 with a build starting from Lightning 2008011604.

The same error has caused a lot of confusion when releasing 0.7. Requesting blocking status.

Comment 1

[Stefan Sitter [:ssitter]]

Works for me after updating from Sunbird/Lightning 0.7 to current 0.8pre builds.

Comment 2

[Sebastian Schwieger]

I cannot reproduce as well if I start from Lightning 0.7.
I can still reproduce with clean profile if switching from Lightning 20080105 to Lightning 20080116.

Comment 3

[Stefan Sitter [:ssitter]]

I can reproduce if upgrading from an older 0.8pre to a current 0.8pre.

However, because the error doesn't occur when upgrading from 0.7 it's not a blocker. But it should stay on the table for retest once the final 0.8 builds are available.

Comment 4

[Sebastian Schwieger]

Note to self/QA: Upgrade path from 0.5 to 0.8 should also be tested.

Comment 5

[Sven Giermann]

I did testing for 0.5 --> 0.8pre, which failed ;-(

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

As ssitter noted in the other bug I can't remember right now, testing 0.5 -> 0.8 will obviously fail since 0.5 -> 0.7 failed. Its the same issue. As long as 0.7 -> 0.8 is fine, I think we are good to go.

I'd still be interested whats causing this though.

Comment 7

[Daniel Boelzle [:dbo]]

I can imagine a rather easy fix checking for either "calendar-main-in-composite" or "lightning-main-in-composite" in calProviderBase; taking this one.

Comment 8

[Daniel Boelzle [:dbo]]

Attachment: fix

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 301735 [details] [diff] [review]
fix

r=philipp

Comment 10

[Daniel Boelzle [:dbo]]

Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.

Comment 11

[Joey Minta]

Comment on attachment 301735 [details] [diff] [review]
fix

+        function takeOverIfNotPresent(oldPref, newPref, dontDeleteOldPref) {
...
+        takeOverIfNotPresent("lightning-main-in-composite", "calendar-main-in-composite");
+        takeOverIfNotPresent("lightning-main-default", "calendar-main-default");

Can someone explain this mysterious third parameter to me? None of the callers use it...

Comment 12

[Daniel Boelzle [:dbo]]

It's a pleasure to do this: I actually recycled this function from another patch that will soon land (presumably post 0.8), i.e. for bug 412800. That patch will set up more composite calendars for today pane et al and take over the current composite props without deleting them.

Comment 13

[Sven Giermann]

(In reply to comment #10)
> Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.

Verified FIXED with Lightning 2008020719 doing an update from 0.5 release.

Comment 14

[Martin Schröder [:mschroeder]]

VERIFIED per comment#13.