Closed
Bug 413183
Opened 17 years ago
Closed 15 years ago
Move the changes done by RemoveVotes and CheckIfVotedConfirmed from process_bug.cgi to Bugzilla::Bug
Categories
(Bugzilla :: Creating/Changing Bugs, enhancement)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: mkanat, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.94 KB,
patch
|
Details | Diff | Splinter Review |
Right now process_bug manually checks if a bug was confirmed by popular vote by being moved to a new product. It does this in the update() loop. Instead, we should have this logic happen inside set_product in Bugzilla::Bug (now that we have set_status).
|
||
Updated•17 years ago
|
Assignee: create-and-change → LpSolit
|
|
||
Comment 1•17 years ago
|
||
Emails are still sent by process_bug.cgi, but this should be addressed by bug 413215.
Attachment #302663 -
Flags: review?(mkanat)
|
|
||
Comment 2•17 years ago
|
||
Forgot to change the returned value.
Attachment #302663 -
Attachment is obsolete: true
Attachment #302664 -
Flags: review?(mkanat)
Attachment #302663 -
Flags: review?(mkanat)
|
Reporter | |
Comment 3•17 years ago
|
||
Comment on attachment 302664 [details] [diff] [review]
patch, v1.1
What I would rather see is a subroutine that adjusts and validates votes on the object and adds a comment to {added_comments} on the other bug, and then does the actual updating during update().
|
|
||
Comment 4•17 years ago
|
||
Comment on attachment 302664 [details] [diff] [review]
patch, v1.1
Yes, you are right. Makes perfect sense.
Attachment #302664 -
Flags: review?(mkanat)
|
|
Reporter | |
Updated•17 years ago
|
|
|
||
Updated•17 years ago
|
Target Milestone: Bugzilla 3.2 → Bugzilla 4.0
|
|
||
Comment 5•15 years ago
|
||
The voting system is no longer in the core code of Bugzilla, so these two subroutines are gone from process_bug.cgi.
Assignee: LpSolit → create-and-change
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WORKSFORME
Target Milestone: Bugzilla 4.0 → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•