413197 - maketoc does not honour hidden content

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Chris Ilias [:cilias]]

On <http://support.mozilla.com/kb/menu_reference-en-US>, the Firefox menu is Mac specific. I can hide it with SHOWFOR, but it is still in the TOC.

Comment 1

[David Tenser [:djst]]

Nelson and I discussed this on IM, but I don't recall the time required to fix this and whether or not it's possible to get this in the 0.6 milestone. Nelson?

Comment 2

[Chris Ilias [:cilias]]

Note to self: When this bug is fixed, fix syntax on "On Windows Vista" and "On Windows 2000 and XP" headings in <http://support.mozilla.com/kb/Profiles>. I had to do some cheating to work around this. :-)

Comment 3

[Nelson Ko [:nkoth]]

This is now on support-stage. (Note it doesn't work if you have more than one maketoc, which I think you don't have).

Comment 4

[Chris Ilias [:cilias]]

Tested on <http://support-stage.mozilla.org/en-US/kb/Menu+Reference>, and it seems to be working. The links on dynamic items ("Exit") need cleaning, but I suppose that's a separate bug, and the links do work.

Comment 5

[Chris Ilias [:cilias]]

This is fixed, right?

Comment 6

[Chris Ilias [:cilias]]

Marking FIXED.

Comment 7

[Nelson Ko [:nkoth]]

This is related to SHOWFOR. In tikilib.php in sumo, you can find code that handles the above toc handling for showfor by {maketoc}. Just do a case insensitive search for "showfor". If showfor remains unchanged, that part will have to be upstreamed for it to work. If showfor is rewritten, then the above also has to be taken into account.

Comment 8

[Nelson Ko [:nkoth]]

This is related to SHOWFOR. In tikilib.php in sumo, you can find code that handles the above toc handling for showfor by {maketoc}. Just do a case insensitive search for "showfor". If showfor remains unchanged, that part will have to be upstreamed for it to work. If showfor is rewritten, then the above also has to be taken into account.