413226 - GCC spews thousands of visibility warnings when compiling Cairo

Status: VERIFIED WORKSFORME

(Core :: Graphics, defect)

Description

[Mats Palmgren (inactive)]

GCC spews thousands of visibility warnings when compiling Cairo:

cairoint.h:2192: warning: redeclaration of '_moz_cairo_clip_preserve' with different visibility (old visibility preserved)
cairo.h:649: warning: previous declaration of '_moz_cairo_clip_preserve' was here
cairoint.h:2193: warning: redeclaration of '_moz_cairo_close_path' with different visibility (old visibility preserved)
cairo.h:585: warning: previous declaration of '_moz_cairo_close_path' was here

This is a problem we need to fix since it makes it hard to see warnings
that flags real problems (bug 413169 as an example).

Comment 1

[Mats Palmgren (inactive)]

In case it's a local problem, this is Ubuntu 7.10 x86_64 with gcc:
gcc version 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)

Comment 2

[Mats Palmgren (inactive)]

BTW, it also doesn't have the desired effect (if I understand the
purpose of these macros correctly).

"objdump -x libthebes.so" tells me:
00039e90 g F .text  0000002f INT__moz_cairo_clip_preserve
00039e90 g F .text  0000002f _moz_cairo_clip_preserve

I think what is desired is something like this:
00038370 l F .text  0000002f .hidden INT__moz_cairo_clip_preserve
00038370 g F .text  0000002f _moz_cairo_clip_preserve

Comment 3

[Mats Palmgren (inactive)]

Attachment: hack

FWIW, this hack seems to give the desired result.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Jeff, is there any chance of getting this hack (or a non-hack accomplishing the same thing) in the tree?

Comment 5

[Matt Woodrow (:mattwoodrow)]

I believe this has been fixed with a cairo update.

Please reopen if you can still reproduce this.

Comment 6

[Mats Palmgren (inactive)]

The warnings about visibility are gone on trunk.  I still get 352 other
warnings when compiling gfx/cairo/