Make it easier for address book based xpcshell unit tests to be used throughout mailnews

RESOLVED FIXED

Status

MailNews Core
Address Book
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

12.84 KB, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
Created attachment 298119 [details] [diff] [review]
The fix

I'm currently writing a unit test for some of the compose code. As this accesses the address book it'd be useful to use the same setup scripts as we do now, but from mailnews/compose/test/unit, not mailnews/addrbook/test/unit.

The xpcshell tests are capable of importing scripts, therefore I want to move the current set-up and clean-up scripts from mailnews/addrbook/test/unit to mailnews/addrbook/test/resource and import them from there. This means they are more accessible from elsewhere, and its clear that they are a resource and not just a test.

Attaching patch...
Attachment #298119 - Flags: superreview?(neil)
Attachment #298119 - Flags: review?(neil)

Updated

11 years ago
Attachment #298119 - Flags: superreview?(neil)
Attachment #298119 - Flags: superreview+
Attachment #298119 - Flags: review?(neil)
Attachment #298119 - Flags: review+
(Assignee)

Comment 1

11 years ago
Checked in -> fixed.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.