gnomestripe: small "warning" icon isn't small size of big "warning" icon, it's probably winstripe icon

RESOLVED INACTIVE

Status

()

Firefox
Theme
--
trivial
RESOLVED INACTIVE
11 years ago
2 days ago

People

(Reporter: Jakub 'Livio' Rusinek, Unassigned)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b3pre) Gecko/2008012004 Fedora/8 (Moonshine) Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b3pre) Gecko/2008012004 Fedora/8 (Moonshine) Minefield/3.0b3pre

icons don't fit

Reproducible: Always

Actual Results:  
not the same icon used in both places

Expected Results:  
everything ok...
(Reporter)

Comment 1

11 years ago
Created attachment 298144 [details]
screenshot
Yes, I know about this. The small icon is one shipped with firefox while the big one is a gtk-stock icon (actually re-themed by the GNOME icon theme).

The solution here will be replacing all error icons with a matching set we will provide at some point. Those icons are M3, so they are not yet complete at this point. Using GTK stock would be nice of cause, but sadly right now GTK only ships the error/warning/question icons at 48x48, but we also need 32x32, 24x24 and 16x16.
(Reporter)

Comment 3

11 years ago
So lets file bug in their bugzilla (I love it!)...
http://bugzilla.gnome.org/show_bug.cgi?id=510889
Jakub, filing bugs like that generally does not help very much. The problem was known it it was clear that we would need to work around it in Firefox 3.

I reassigned the request on GNOME's bugzilla.
(Reporter)

Comment 5

10 years ago
Created attachment 301949 [details]
better example of inconsistence
(Reporter)

Updated

10 years ago
Blocks: 381206
Component: OS Integration → Theme
QA Contact: os.integration → theme
Version: unspecified → Trunk
Looks like GTK refuses to add more icons sizes... Well, we need to do them either way for FF3. Hopefully done, soon. Then we will need to hunt all those wrong icons down, won't be easy... ;)
(Reporter)

Comment 7

10 years ago
First is base64 encoded icon, second is used as favicon, third is in "add exception", fourth is on "loading warning page"...

I don't remember more.

Comment 8

10 years ago
Don't know why is imporant to know here the icons are used, but I found that this files are the ones that use it:

chrome/pippki/content/pippki/exceptionDialog.xul:
<image src="chrome://global/skin/icons/warning-large.png"/>

chrome/classic/skin/classic/global/config.css:
list-style-image: url("chrome://global/skin/icons/warning-large.png");

chrome/classic/skin/classic/global/console/console.css:
list-style-image: url("chrome://global/skin/console/bullet-warning.png");

chrome/classic/skin/classic/mozapps/update/updates.css:
list-style-image: url("chrome://global/skin/icons/Warning.png");

--

This one is for the Console icon:

chrome/classic/skin/classic/global/console/console.css:
list-style-image: url("chrome://global/skin/console/console-toolbar.png");

Comment 9

10 years ago
I found all images with this script:

#!/bin/sh

for i in `find . -name "*.jar"`; do
	unzip -d "${i%.jar}" "${i}"

	rm "${i}"
done

mkdir images

for i in `find . \
-name "*.bmp" -or -name "*.bmP" -or -name "*.bMp" -or -name "*.bMP" -or \
-name "*.Bmp" -or -name "*.BmP" -or -name "*.BMp" -or -name "*.BMP" -or \
-name "*.gif" -or -name "*.giF" -or -name "*.gIf" -or -name "*.gIF" -or \
-name "*.Gif" -or -name "*.GiF" -or -name "*.GIf" -or -name "*.GIF" -or \
-name "*.jpg" -or -name "*.jpG" -or -name "*.jPg" -or -name "*.jPG" -or \
-name "*.Jpg" -or -name "*.JpG" -or -name "*.JPg" -or -name "*.JPG" -or \
-name "*.png" -or -name "*.pnG" -or -name "*.pNg" -or -name "*.pNG" -or \
-name "*.Png" -or -name "*.PnG" -or -name "*.PNg" -or -name "*.PNG" -or \
-name "*.xpm" -or -name "*.xpM" -or -name "*.xPm" -or -name "*.xPM" -or \
-name "*.Xpm" -or -name "*.XpM" -or -name "*.XPm" -or -name "*.XPM" -or \
-name "*.jpeg" -or -name "*.jpeG" -or -name "*.jpEg" -or -name "*.jpEG" -or \
-name "*.jPeg" -or -name "*.jPeG" -or -name "*.jPEg" -or -name "*.jPEG" -or \
-name "*.Jpeg" -or -name "*.JpeG" -or -name "*.JpEg" -or -name "*.JpEG" -or \
-name "*.JPeg" -or -name "*.JPeG" -or -name "*.JPEg" -or -name "*.JPEG"`; do
	name=`basename "${i}"`

	while [ -e "images/${name}" ]; do
		name="_${name}"
	done

	cp "${i}" "images/${name}"
done

Once I found which images should be replaced, the ones with the yellow alert icon, I did:

grep -RFi -e "Warning.png" -e "warning.gif" -e "warning-large.png" -e "bullet-warning.png" -e "console-toolbar.png" .

In firefox directory, to get all occurrences of them in the source.
Use this for your |for| loop instead:

for i in `find . \
-iname "*.bmp" -or -iname "*.gif" -or -iname "*.jpg" -or -iname "*.png" -or \
-iname "*.xpm" -or -iname "*.jpeg"`; do

Comment 11

10 years ago
I searched for the base64 encodings of the files mentioned in comment 8, and found nothing.

Comment 12

10 years ago
(In reply to comment #10)
> Use this for your |for| loop instead:
> 
> for i in `find . \
> -iname "*.bmp" -or -iname "*.gif" -or -iname "*.jpg" -or -iname "*.png" -or \
> -iname "*.xpm" -or -iname "*.jpeg"`; do
> 

The find implementation I use does not have that operator.
(In reply to comment #12)
> The find implementation I use does not have that operator.

That's too bad.

Comment 14

10 years ago
(In reply to comment #13)
> That's too bad.

Personally, I'd consider unfortunate the fact that the SUS does not define an operator like that.

Comment 15

9 years ago
(In reply to comment #14)
> (In reply to comment #13)
> > That's too bad.
> 
> Personally, I'd consider unfortunate the fact that the SUS does not define an
> operator like that.

It does: -o
(The GNU Find docs even say that -or is "Same as expr1 -o expr2, but not POSIX compliant.")

Comment 16

2 days ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 2 days ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.