Closed Bug 413258 Opened 18 years ago Closed 18 years ago

When setting a flag on an attachment on bug creation, an incorrect message is displayed

Categories

(Bugzilla :: Attachments & Requests, defect)

3.1.2
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.2

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

(Keywords: regression, Whiteboard: [wanted-bmo])

Attachments

(1 file)

On bug creation, attach a file and set the flag to +/-/? (doesn't matter which flag status is chosen). Flag::FormToNewFlags() incorrectly triggers the 'unexpected_flag_types' message if the product/component also allows bug flags. This is because the code makes no distinction between bug and attachment flag types and considers some of them as invalid flag types for bugs, respectively attachments.
Whiteboard: [wanted-bmo]
Hum, wait, 3.0.x is not affected. b.m.o is because justdave backported it.
Target Milestone: Bugzilla 3.0 → Bugzilla 3.2
Version: 3.0.3 → 3.1.2
Attached patch patch, v1 — — Splinter Review
Attachment #298159 - Flags: review+
Flags: approval+
Checking in Bugzilla/Flag.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v <-- Flag.pm new revision: 1.89; previous revision: 1.88 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: