41331 - lxr file output has illegal html, doesn't work in mozilla

Status: RESOLVED FIXED

(Webtools Graveyard :: MXR, defect, P3)

Description

[Akkana Peck]

If I do an lxr file search and end up at the given url, 4.7 will show me boxes
for things like cvs log and cvs blame at the top (and I use these many times a
day!) but mozilla doesn't show those boxes.

Running the page through validator.w3.org says:
Error: value of attribute "VALIGN" cannot be "CENTER"; must be one of "TOP",
"MIDDLE", "BOTTOM", "BASELINE"

(It has a few other errors, too, but I expect that's the one causing the
problem.)

I guess gecko is being picky and refusing to show me the table cells with
attributes it doesn't like?

Rick, I remember a long time ago you said that we would have a way to tell the
user when we think a page is bad, so that users don't just say "Oh, well, this
browser sucks because it doesn't show me pages that work fine in my old
browser."  Is that in place now, and if so, how do I turn it on?  I couldn't
find anything in the prefs dialog.

Comment 1

[rickg]

We used to have a mode where the parser could report the quality of the page 
back up to the UI, and it would show up as a little red, orange or green LED 
image in the bottom right corner of our UI. That codes long gone, but the parser 
still knows the answer. If UI folks want to reenable the UI, I'll hook up the 
reporting code.

I'd be willing to bet that the problem with LXR is not the attributes. Bad 
attributes are simply ignored. If you have a test page you can send me, I can 
help track down the real problem.

Comment 2

[Dawn Endico]

it seems like this should work ok in quirks mode. however lxr
throws up a html 4.0 doctype. maybe a quick fix would be to nuke
that line.

I think this counts as an example of a broken url
http://lxr.mozilla.org/seamonkey/source/dom/src/coreDOM/nsJSCharacterData.cpp

Comment 3

[Jesse Ruderman]

The boxes show up on 2000 110104 Win98.  Is this a linux-only problem, or is 
Mozilla being more lenient now?

Comment 4

[Akkana Peck]

Yep, the boxes show up now -- looks like either someone fixed the lxr page, or
it's because gecko turned off strict parsing.