Closed Bug 413363 Opened 17 years ago Closed 14 years ago

Dialog for importing your certificates in Certificate Manager has wrong title

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b5

People

(Reporter: efung, Assigned: wesongathedeveloper)

Details

(Whiteboard: [psm-cert-manager][good first bug])

Attachments

(1 file, 1 obsolete file)

Patch
1.96 KB, patch
KaiE
: review+
benjamin
: approval2.0+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.11) Gecko/20071204 Ubuntu/7.10 (gutsy) Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.11) Gecko/20071204 Ubuntu/7.10 (gutsy) Firefox/2.0.0.11

In the Certificate Manager, under the Your Certificates tab, clicking on Import brings up a dialog box whose title is "File Name to Restore". It should probably say something about importing a certificate.

Reproducible: Always

Steps to Reproduce:
1. In Firefox, click on Edit | Preferences.
2. Select Advanced. Select the Encryption tab.
3. Click on View Certificates. Select the Your Certificates tab.
4. Click on Import.

Actual Results:  
The title of the dialog box is "File Name to Restore".

Expected Results:  
The title should be something like "Select File containing your certificate to import".
That might be a little long, maybe "Certificate file to import"?
Assignee: dveditz → kengert
Status: UNCONFIRMED → NEW
Component: Security → Security: PSM
Ever confirmed: true
QA Contact: toolkit → psm
Concur on "Certificate file to import"

confirmed on
build info:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008012104 Minefield/3.0b3pre
Assignee: kaie → nobody
Whiteboard: [psm-cert-manager][good first bug]
Attached patch Patch (obsolete) — — Splinter Review 
Assignee: nobody → wesongathedeveloper
Status: NEW → ASSIGNED

        Attachment #454564 -
        Flags: review?(kaie)

    
    

    
  
Comment on attachment 454564 [details] [diff] [review]
Patch

Thanks for your patch. Whenever we change the contents of a string, we must update the "label", too. This is necessary, so that localizers will detect the need for a new translation.

Please change
  chooseP12RestoreFileDialog
to
  chooseP12RestoreFileDialog2

and search the code for occurrences of chooseP12RestoreFileDialog and change those, too.

        Attachment #454564 -
        Flags: review?(kaie) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch
        — 
          — Splinter Review
      

    


  

        Attachment #454564 -
        Attachment is obsolete: true

        Attachment #454573 -
        Flags: review?(kaie)

    
    

    
  
Comment on attachment 454573 [details] [diff] [review]
Patch

r=kaie

        Attachment #454573 -
        Flags: review?(kaie) → review+

    
  
Keywords: checkin-needed

    
    

    
  
patch needs approval2.0+ to land
Keywords: checkin-needed

    
  

        Attachment #454573 -
        Flags: approval2.0?

    
  

        Attachment #454573 -
        Flags: approval2.0? → approval2.0+

    
  
Keywords: checkin-needed

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/eb29d2013e86
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
OS: Linux → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b5

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: