413462 - GTK print dialog has incorrect filename extension for Print to File

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[James Graham]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b3pre) Gecko/2008012104 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b3pre) Gecko/2008012104 Minefield/3.0b3pre

Selecting Print to File the default filename is mozilla.ps, but the default output format is PDF. The filename extension should match the output format.

Reproducible: Always

Comment 1

[Michael Ventnor]

Attachment: Patch

This works.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Changing the output format to match the file name doesn't seem like the right fix to this bug.

I think the file name in the dialog should change to match the currently selected output format.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

In other words, when we first discover the current file format is PS or PDF, and every time that changes, if the new format is PS and the current file name ends in .pdf, change it to .ps, or if the new format is PDF and the current file name ends in .ps, change it to .pdf.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 301738 [details] [diff] [review]
Patch

alright then

Comment 5

[Michael Ventnor]

Comment on attachment 301738 [details] [diff] [review]
Patch

For the record, we had a little chat on the side about this bug ;)

This is a trivial change to make print-to-file slightly less irritating.

Comment 6

[Damon Sicore (:damons)]

Comment on attachment 301738 [details] [diff] [review]
Patch

a1.9+=damons

Comment 7

[Reed Loden [:reed]]

Checking in widget/src/gtk2/nsPrintSettingsGTK.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsPrintSettingsGTK.cpp,v  <--  nsPrintSettingsGTK.cpp
new revision: 1.5; previous revision: 1.4
done