Closed Bug 413484 Opened 12 years ago Closed 12 years ago

cvs remove unused files from calendar/resources/content

Categories

(Calendar :: General, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sipaq, Assigned: sipaq)

Details

Attachments

(1 file)

We currently do not package the following files:

- calPrintEngine.css
- calPrintEngine.js
- calPrintEngine.xul
- calendarService.js
- outlookImportBooleanDialog.js
- outlookImportBooleanDialog.xul
- selectAddressesDialog.js

Therefore they should be cvs removed.

In addition I'd like to package the sound.wav file directly in calendar/resources/jar.mn instead of calendar/base/jar.mn

The opposite should be done for the calendar-dnd-listener.js file.
Additionally
agenda-tree-overlay.xul
agenda-tree.js

in calendar/lightning/content should also be removed
(In reply to comment #0)
> We currently do not package the following files:
[...]
> - calendarService.js
[...]
> Therefore they should be cvs removed.

calendarService.js is directly packaged because it's a component, also see http://mxr.mozilla.org/seamonkey/source/calendar/installer/windows/packages-static#226 for windows packaging.
Attached patch PatchSplinter Review
Attachment #299264 - Flags: review?(ctalbert)
Attachment #299264 - Flags: review?(ctalbert) → review?(philipp)
Comment on attachment 299264 [details] [diff] [review]
Patch

Why should sound.wav go into resources? It is used by both sunbird and lightning, and we are rather trying to get rid of resources/

otherwise r=philipp
Attachment #299264 - Flags: review?(philipp) → review+
Philipp, sound.wav does not go into resources, it is already there! 

See http://lxr.mozilla.org/seamonkey/source/calendar/resources/content/sound.wav

The patch just fixes the issue of sound.wav being included in base, which makes no sense, since there is jar.mn file in resources as well.
As far as I know, the resources/ dir is not in the lightning Makefile.in, so the jar.mn in resources is never parsed for lightning.
Patch checked in on HEAD and MOZILLA_1_8_BRANCH after discussion with Philipp on IRC. His comment 6 is obsolete.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.