413489 - support configure.in patches on the try server

Status: VERIFIED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

There was an e-mail sent to build@m.o today wondering about how to test configure.in changes on the try server. We require Autoconf 2.13 to do this; the slaves have it as 'autoconf-2.13'. By setting $AUTOCONF in the mozconfig files, we should be able to force it to use that version when re-generating configure. The only thing I'm unsure about is whether to put RUN_AUTOCONF_LOCALLY in the try server mozconfigs, or have people set that when they want it. Is there any disadvantage/risk in running it every time?

Comment 1

[Benjamin Smedberg]

There is little/no risk in running it every time in clobber builds. In depend builds it's likely to trigger a world-rebuild more often than necessary. But since the tryserver builds are always clobber, you should be able to set it safely.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: [checked in] always regenerate configure on the try server, to support configure.in patches

I've tested these new mozconfigs on the try server slaves, they should be fine.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 298730 [details] [diff] [review]
[checked in] always regenerate configure on the try server, to support configure.in patches

Checking in mozconfig-linux;
/cvsroot/mozilla/tools/buildbot-configs/tryserver/mozconfig-linux,v  <--  mozconfig-linux
new revision: 1.2; previous revision: 1.1
done
Checking in mozconfig-mac;
/cvsroot/mozilla/tools/buildbot-configs/tryserver/mozconfig-mac,v  <--  mozconfig-mac
new revision: 1.2; previous revision: 1.1
done
Checking in mozconfig-win32;
/cvsroot/mozilla/tools/buildbot-configs/tryserver/mozconfig-win32,v  <--  mozconfig-win32
new revision: 1.2; previous revision: 1.1
done

Comment 4

[[e-mail] (:bhearsum)]

Hey Peter, configure.in changes should be supported now. Can you give it another try when you get a chance?

Comment 5

[Peter Weilbacher]

Will do that, thanks Ben!

Comment 6

[Peter Weilbacher]

Yes, this works fine now. I see

Generating /builds/buildbot/sendchange-slave/sendchange-linux/mozilla/configure using autoconf
cd /builds/buildbot/sendchange-slave/sendchange-linux/mozilla; /usr/local/bin/autoconf-2.13
make[1]: Entering directory `/builds/buildbot/sendchange-slave/sendchange-linux/mozilla'
Generating /builds/buildbot/sendchange-slave/sendchange-linux/mozilla/nsprpub/configure using autoconf
cd /builds/buildbot/sendchange-slave/sendchange-linux/mozilla/nsprpub; /usr/local/bin/autoconf-2.13
cd /builds/buildbot/sendchange-slave/sendchange-linux/mozilla/objdir
/builds/buildbot/sendchange-slave/sendchange-linux/mozilla/configure

in the logs of the Linux machine, and similar for Mac and Windows, too.

Comment 7

[[e-mail] (:bhearsum)]

Moving try server bugs to the new component.