413493 - Incorrect naming of label and accesskey

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Friedel Wolff]

In toolkit/chrome/mozapps/downloads/downloads.dtd a lable and an accesskey is incorrectly named. This makes automatic matching and QA in all translations  impossible. 

cmd.show.labelMac
cmd.show.accesskeyMac

should for example be

cmd.showMac.label
cmd.showMac.accesskey

Comment 1

[Shawn Wilsher :sdwilsh]

do we still want to fix this since it's after the string freeze?

Comment 2

[Vlado Valastiak [:wladow]]

Attachment: patch

I think it's still time to get this in as many l10n bugs still wait for checkin and this is easy to review and low-risk patch.

Comment 3

[Reed Loden [:reed]]

Comment on attachment 299459 [details] [diff] [review]
patch

No ui-review is necessary for this, but string freeze has already happened. However, as this does affect localizers, it may be taken anyway.

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 299459 [details] [diff] [review]
patch

r=sdwilsh

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 299459 [details] [diff] [review]
patch

a=beltzner

Comment 6

[Reed Loden [:reed]]

Checking in toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd,v  <--  downloads.dtd
new revision: 1.23; previous revision: 1.22
done
Checking in toolkit/mozapps/downloads/content/downloads.xul;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.xul,v  <--  downloads.xul
new revision: 1.47; previous revision: 1.46
done

Comment 7

[Vlado Valastiak [:wladow]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; sk; rv:1.9b3pre) Gecko/2008013004 Minefield/3.0b3pre