413605 - allow to use JS for the selected accessible in the accessibleTree view

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

allow to use JS for the selected accessible in the accessibleTree view

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch2

Comment 2

[[e-mail]]

Is there a particular reason you're not reusing the existing JS evaluator?

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> Is there a particular reason you're not reusing the existing JS evaluator?
> 

it has a bit different logic. JS evaluator evaluates JS expression and shows the result in new window. Here I need more than just expression. I need to evaluate JS script (several expressions). Therefore proposed evalJSDialog uses multiline textbox to  type script and has output window to write results.

Comment 4

[[e-mail]]

Comment on attachment 298672 [details] [diff] [review]
patch2

Well, I still think I'd prefer a unified evaluator, and I also think it might be helpful to output the result by default (unless it is undefined).

>+  return node.accessible;s
Stray s?

>+function execute()
>+{
>+  if (!gAcc)
>+    return;
How can this be true?

>+  try {
>+    var f = Function("accessible", expr);
>+    var result = f(gAcc);
>+      
>+    } catch (ex) {
>+      output(ex);
>+    }
Funky indentation.

>Index: extensions/inspector/resources/locale/jar.mn
Don't forget to update ALL_LOCALES.

>+  <!ENTITY btnEvaluateJS.label "Evaluate">
>+  <!ENTITY btnEvaluateJS.accesskey "e">
>+  
>+  <!ENTITY txtInputArea.label "Input Area (use 'accessible' variable to operate with the selected accessible and 'output' function to write into 'Output Area' window): ">
>+  <!ENTITY txtInputArea.accesskey "i">
>+  <!ENTITY txtOutputArea.label "Output Area: ">
>+  <!ENTITY txtOutputArea.accesskey "o">
All accesskeys should be uppercase to match their labels.

Comment 5

[Shawn Wilsher :sdwilsh]

Comment on attachment 298672 [details] [diff] [review]
patch2

s/application\/x-javascript/application\/javascript/g

>+/**
>+ * Return accessible of the tree node pointed by the given
>+ * row index.
>+ *
>+ * @param aRow - row index.
nit:
@param aRow
       The row index to get the accessible from.
@returns ...

locales break the build system - so remove everything but english from the Makefile.

r=sdwilsh

Comment 6

[alexander :surkov (:asurkov)]

(In reply to comment #4)
> (From update of attachment 298672 [details] [diff] [review])
> Well, I still think I'd prefer a unified evaluator, and I also think it might
> be helpful to output the result by default (unless it is undefined).

I would like to have the unique evaluator though I'm not sure how the combined one should looks. I'll file following up bug for this.

Comment 7

[alexander :surkov (:asurkov)]

Attachment: patch3

with Neil's, Shawn's comments

Comment 8

[alexander :surkov (:asurkov)]

(In reply to comment #4)

> >+function execute()
> >+{
> >+  if (!gAcc)
> >+    return;
> How can this be true?

it can't be true actually until someone another open the dialog and forget to pass argument. It's just additional protection. But if you would like to remove it then I will.

Comment 9

[Damon Sicore (:damons)]

Comment on attachment 299965 [details] [diff] [review]
patch3

a1.9+=damons

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 299965 [details] [diff] [review]
patch3

not necessary for b3, can land when we reopen

Comment 11

[alexander :surkov (:asurkov)]

checked in

Comment 12

[alexander :surkov (:asurkov)]

I filed bug 415879 to get unified JS evaluator.