413623 - Add Security Exception dialog is unusable at high dpi

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[Michaël Arnauts]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008012204 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008012204 Minefield/3.0b3pre

The Add Security Exception dialog is unusable at high dpi. To make things clear, i've attached a screenshot.



Reproducible: Always

Steps to Reproduce:
1. use high dpi
2. go to tools > options > advanced > encryption > view certificats > servers > add exception (or visit to a page with a flawed certificate, and click the add exception button
3. click the get certificate button
Actual Results:  
the "certificate status" box enlarges, and pushes the confirm security exception buttons out of view

Expected Results:  
the "certificate status" box should'nt enlarge

Comment 1

[Michaël Arnauts]

Attachment: screenshot

the window at the left is when the dialog is opened
the window at the right is when i entered a site, and clicked the "get certificate" button

Comment 2

[Mike Schroepfer]

Jonatha should we block on this?

Comment 3

[Johnathan Nightingale [:johnath]]

(In reply to comment #2)
> Jonatha should we block on this?

Given that I think on Vista Michaël wouldn't even have the option to resize the dialog, and that it pushes the buttons right off, yeah, I think we need to fix this.  My hope is that it is a simple CSS fix.

I recommend P2 or P3 blocking and I'll look at it this week.  If worst came to worst, we could fix it in a point release, but I'd really rather not have large-text users' first experience with this dialog be a broken one.

Comment 4

[Johnathan Nightingale [:johnath]]

Attachment: Style the message box overflow:auto

This should be all that's needed, I think.  I'll try server it overnight and give it a shot tomorrow on a high-dpi Vista.

Comment 5

[Kai Engert [:KaiE:]]

Comment on attachment 301616 [details] [diff] [review]
Style the message box overflow:auto

if you find this works, r=kengert

Comment 6

[Johnathan Nightingale [:johnath]]

Attachment: Better fix - wrap the content in an inner vbox

Sorry for the re-review Kai, the last one looked a bit broken on Vista because the caption for the groupbox was brought into the box once overflow was set.  This version wraps the offending content in its own vbox with overflow: auto.

This is the ignore-whitespace version of the patch for easy review, in my checkin version, I will indent the content under the vbox properly.

I'll attach a screenshot of the end result.

Comment 7

[Johnathan Nightingale [:johnath]]

Attachment: dialog on vista with fix

Comment 8

[Johnathan Nightingale [:johnath]]

Attachment: Exception dialog in overflow on mac

On all platforms, the scrollbars only show up when needed, so typical behaviour shouldn't be any different.

Comment 9

[Kai Engert [:KaiE:]]

Comment on attachment 301677 [details] [diff] [review]
Better fix - wrap the content in an inner vbox

r=kengert

Comment 10

[Johnathan Nightingale [:johnath]]

Checking in security/manager/pki/resources/content/exceptionDialog.xul;
/cvsroot/mozilla/security/manager/pki/resources/content/exceptionDialog.xul,v  <--  exceptionDialog.xul
new revision: 1.7; previous revision: 1.6
done

Comment 11

[[e-mail]]

Actually the real bug here is that the dialog is pixel sized; if it used em/ch units instead then it would scale more appropriately in the first place.