413672 - email_in.pl incorrectly rejects quoted charsets

Status: RESOLVED FIXED

(Bugzilla :: Incoming Email, defect)

Description

[Frédéric Buclin]

Attachment: patch, v1

email_in.pl fails to parse

  Content-Type: text/plain; charset="UTF-8"

despite it's a valid header. The reason is that bug 366296, which introduced the parsing for the charset, doesn't expect quotes in it: /charset=([^;]+)/. This makes several incoming emails to be rejected.

Comment 1

[Max Kanat-Alexander]

Comment on attachment 298722 [details] [diff] [review]
patch, v1

No, that will include the final quote in the charset.

Comment 2

[Frédéric Buclin]

Comment on attachment 298722 [details] [diff] [review]
patch, v1

>+        if ($ct =~ /charset="?([^;"]+)/) {

Max, the final quote is excluded from the charset. I wrote [^;"]+, not [^;]+. Please reconsider.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 298722 [details] [diff] [review]
patch, v1

Ohhh, duh! :-) Okay. :-)

Comment 4

[Frédéric Buclin]

tip:

Checking in email_in.pl;
/cvsroot/mozilla/webtools/bugzilla/email_in.pl,v  <--  email_in.pl
new revision: 1.13; previous revision: 1.12
done

3.0.3:

Checking in email_in.pl;
/cvsroot/mozilla/webtools/bugzilla/email_in.pl,v  <--  email_in.pl
new revision: 1.5.2.5; previous revision: 1.5.2.4
done