413693 - browser.places.createdSmartBookmarks should contain folder id

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P2)

Description

[Dietrich Ayala (:dietrich)]

We're going to be making some changes that affect how some of the smart queries are constructed. This means another migration of existing queries.

However, given how late in the beta cycle it is, it's not acceptable to add another folder like last time.

Instead we should store the smart bookmarks folder id in the pref, and have it's default be -1 (not created). This will allow us to delete the old and force recreation without duplicating the folder.

Comment 1

[Al Billings [:abillings - ex-MoCo]]

When do we plan to do this and check in the work? I don't see how this will make Beta 3.

Comment 2

[Dietrich Ayala (:dietrich)]

we should probably use an annotation as done in the organizer left pane.

Comment 3

[Marco Bonardo [:mak]]

Really, we should use an anno, and that anno should contain a version number of the queries. We don't actually have correct migration paths for the queries. See for example Bug 385245 where Ondrej need to change a Smart bookmark query. He has to hack around to detect that with a pref because we don't have an easy way to detect smart queries version.

We should move to something similar to SCHEMA migration of the db, you have a queries version in a frontend CONST, you read the anno, and you can migrate forward or backward without any problem removing old folder, changing queries and so on...

Comment 4

[Dietrich Ayala (:dietrich)]

fixed in bug 421483.

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv