413721 - the (AOL/Netscape) redirection type code is not used and should be removed

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Magnus Melin [:mkmelin]]

As discussed in bug 171846 comment 7 ->

"The redirector type stuff is not used anymore. It was used to talk to AOL (and
AOL properties like Compuserve and Netscape)'s IMAP server - it should be
stripped out of the code [...]"

This patch removes the redirectionType usages and code that are no-op after it's removed, hope I got most of it. 

I'm not sure if there are specific things that should be tested for. Normal IMAP operation is ok, sending mail works, account creation also.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: [checked in] proposed fix - first part

Comment 2

[David :Bienvenu]

Comment on attachment 298770 [details] [diff] [review]
[checked in] proposed fix - first part

that's great, Magnus. The other thing you can remove is RequestOverrideInfo - that just has to do with the redirectors. And nsIMsgLogonRedirector.idl can go away completely.

Comment 3

[Magnus Melin [:mkmelin]]

Ok, I can do that in a follow up patch, the current one is fairly large already.

mscott: were you ok with removing this?

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 298770 [details] [diff] [review]
[checked in] proposed fix - first part

David, was this good for a sr too?

Comment 5

[David :Bienvenu]

Comment on attachment 298770 [details] [diff] [review]
[checked in] proposed fix - first part

sure, thx, Magnus.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 298770 [details] [diff] [review]
[checked in] proposed fix - first part

First part checked in.

Checking in mail/base/content/commandglue.js;
/cvsroot/mozilla/mail/base/content/commandglue.js,v  <--  commandglue.js
new revision: 1.90; previous revision: 1.89
done
Checking in mail/base/content/messenger.xul;
/cvsroot/mozilla/mail/base/content/messenger.xul,v  <--  messenger.xul
new revision: 1.86; previous revision: 1.85
done
Checking in mailnews/base/ispdata/aol.rdf;
/cvsroot/mozilla/mailnews/base/ispdata/aol.rdf,v  <--  aol.rdf
new revision: 1.10; previous revision: 1.9
done
Checking in mailnews/base/prefs/resources/content/AccountWizard.js;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/AccountWizard.js,v  <--  AccountWizard.js
new revision: 1.137; previous revision: 1.136
done
Checking in mailnews/base/prefs/resources/content/am-identity-edit.js;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/am-identity-edit.js,v  <--  am-identity-edit.js
new revision: 1.14; previous revision: 1.13
done
Checking in mailnews/base/prefs/resources/content/am-server.js;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/am-server.js,v  <--  am-server.js
new revision: 1.72; previous revision: 1.71
done
Checking in mailnews/base/prefs/resources/content/am-smtp.js;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/am-smtp.js,v  <--  am-smtp.js
new revision: 1.19; previous revision: 1.18
done
Checking in mailnews/base/prefs/resources/content/aw-login.js;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/aw-login.js,v  <--  aw-login.js
new revision: 1.19; previous revision: 1.18
done
Checking in mailnews/base/prefs/resources/content/aw-server.js;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/aw-server.js,v  <--  aw-server.js
new revision: 1.46; previous revision: 1.45
done
Checking in mailnews/base/public/nsIMsgIncomingServer.idl;
/cvsroot/mozilla/mailnews/base/public/nsIMsgIncomingServer.idl,v  <--  nsIMsgIncomingServer.idl
new revision: 1.105; previous revision: 1.104
done
Checking in mailnews/base/resources/content/commandglue.js;
/cvsroot/mozilla/mailnews/base/resources/content/commandglue.js,v  <--  commandglue.js
new revision: 1.282; previous revision: 1.281
done
Checking in mailnews/base/resources/content/folderPane.xul;
/cvsroot/mozilla/mailnews/base/resources/content/folderPane.xul,v  <--  folderPane.xul
new revision: 1.105; previous revision: 1.104
done
Checking in mailnews/base/src/nsMessengerWinIntegration.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMessengerWinIntegration.cpp,v  <--  nsMessengerWinIntegration.cpp
new revision: 1.76; previous revision: 1.75
done
Checking in mailnews/base/src/nsMsgDBView.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMsgDBView.cpp,v  <--  nsMsgDBView.cpp
new revision: 1.301; previous revision: 1.300
done
Checking in mailnews/base/src/nsMsgDBView.h;
/cvsroot/mozilla/mailnews/base/src/nsMsgDBView.h,v  <--  nsMsgDBView.h
new revision: 1.106; previous revision: 1.105
done
Checking in mailnews/base/src/nsMsgFolderDataSource.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMsgFolderDataSource.cpp,v  <--  nsMsgFolderDataSource.cpp
new revision: 1.219; previous revision: 1.218
done
Checking in mailnews/base/src/nsMsgFolderDataSource.h;
/cvsroot/mozilla/mailnews/base/src/nsMsgFolderDataSource.h,v  <--  nsMsgFolderDataSource.h
new revision: 1.83; previous revision: 1.82
done
Checking in mailnews/base/src/nsMsgRDFUtils.h;
/cvsroot/mozilla/mailnews/base/src/nsMsgRDFUtils.h,v  <--  nsMsgRDFUtils.h
new revision: 1.70; previous revision: 1.69
done
Checking in mailnews/base/util/nsMsgIncomingServer.cpp;
/cvsroot/mozilla/mailnews/base/util/nsMsgIncomingServer.cpp,v  <--  nsMsgIncomingServer.cpp
new revision: 1.265; previous revision: 1.264
done
Checking in mailnews/compose/public/nsISmtpServer.idl;
/cvsroot/mozilla/mailnews/compose/public/nsISmtpServer.idl,v  <--  nsISmtpServer.idl
new revision: 1.18; previous revision: 1.17
done
Checking in mailnews/compose/src/nsSmtpProtocol.cpp;
/cvsroot/mozilla/mailnews/compose/src/nsSmtpProtocol.cpp,v  <--  nsSmtpProtocol.cpp
new revision: 1.202; previous revision: 1.201
done
Checking in mailnews/compose/src/nsSmtpServer.cpp;
/cvsroot/mozilla/mailnews/compose/src/nsSmtpServer.cpp,v  <--  nsSmtpServer.cpp
new revision: 1.59; previous revision: 1.58
done
Checking in mailnews/imap/public/nsIImapIncomingServer.idl;
/cvsroot/mozilla/mailnews/imap/public/nsIImapIncomingServer.idl,v  <--  nsIImapIncomingServer.idl
new revision: 1.42; previous revision: 1.41
done
Checking in mailnews/imap/public/nsIMsgLogonRedirector.idl;
/cvsroot/mozilla/mailnews/imap/public/nsIMsgLogonRedirector.idl,v  <--  nsIMsgLogonRedirector.idl
new revision: 1.11; previous revision: 1.10
done
Checking in mailnews/imap/src/nsImapIncomingServer.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsImapIncomingServer.cpp,v  <--  nsImapIncomingServer.cpp
new revision: 1.375; previous revision: 1.374
done
Checking in mailnews/imap/src/nsImapIncomingServer.h;
/cvsroot/mozilla/mailnews/imap/src/nsImapIncomingServer.h,v  <--  nsImapIncomingServer.h
new revision: 1.58; previous revision: 1.57
done
Checking in mailnews/imap/src/nsImapMailFolder.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsImapMailFolder.cpp,v  <--  nsImapMailFolder.cpp
new revision: 1.795; previous revision: 1.794
done
Checking in mailnews/imap/src/nsImapProtocol.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsImapProtocol.cpp,v  <--  nsImapProtocol.cpp
new revision: 1.675; previous revision: 1.674
done

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: proposed fix - part2

Gets rid of RequestOverrideInfo nsIMsgLogonRedirector.idl and some other obsolete methods/variables.

Comment 8

[David :Bienvenu]

Comment on attachment 308211 [details] [diff] [review]
proposed fix - part2

thx, Magnus

Comment 9

[Magnus Melin [:mkmelin]]

That was quick, thx!

Part two checked in.

Checking in mailnews/compose/src/nsSmtpProtocol.cpp;
/cvsroot/mozilla/mailnews/compose/src/nsSmtpProtocol.cpp,v  <--  nsSmtpProtocol.cpp
new revision: 1.203; previous revision: 1.202
done
Checking in mailnews/compose/src/nsSmtpProtocol.h;
/cvsroot/mozilla/mailnews/compose/src/nsSmtpProtocol.h,v  <--  nsSmtpProtocol.h
new revision: 1.63; previous revision: 1.62
done
Checking in mailnews/imap/public/Makefile.in;
/cvsroot/mozilla/mailnews/imap/public/Makefile.in,v  <--  Makefile.in
new revision: 1.23; previous revision: 1.22
done
Removing mailnews/imap/public/nsIMsgLogonRedirector.idl;
/cvsroot/mozilla/mailnews/imap/public/nsIMsgLogonRedirector.idl,v  <--  nsIMsgLogonRedirector.idl
new revision: delete; previous revision: 1.11
done
Checking in mailnews/imap/src/nsImapIncomingServer.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsImapIncomingServer.cpp,v  <--  nsImapIncomingServer.cpp
new revision: 1.376; previous revision: 1.375
done
Checking in mailnews/imap/src/nsImapIncomingServer.h;
/cvsroot/mozilla/mailnews/imap/src/nsImapIncomingServer.h,v  <--  nsImapIncomingServer.h
new revision: 1.59; previous revision: 1.58
done
Checking in mailnews/imap/src/nsImapProtocol.h;
/cvsroot/mozilla/mailnews/imap/src/nsImapProtocol.h,v  <--  nsImapProtocol.h
new revision: 1.207; previous revision: 1.206
done

->FIXED