41377 - NS_ConvertUTF8toUCS2::Init() treats aLength as chars, not bytes

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect, P3)

Description

[Chris Waterson]

erik suggested that aLength should mean "the number of bytes in this string that 
you want to convert" as opposed to "the number of characters in this string that 
you want to convert". This would make it consistent with the way the Unicode 
encoders in I18n work.

Thought I'd put it into a bug for posterity's sake.

Comment 1

[Chris Waterson]

Attachment: proposed fix, which treats aLength as bytes count, not character count

Comment 2

[Chris Waterson]

scc: this is eventually going to be code that will work via nsCharTraits. Can
you make the call wrt. whether or not you want aLength to mean characters or
bytes?

Comment 3

[Chris Waterson]

scc, i'm giving this to you to decide what's right.

Comment 4

[Scott Collins]

moving out

Comment 5

[Scott Collins]

re-targeting milestones, starting from a clean slate

Comment 6

[Scott Collins]

giving up ancient string bugs to the new string owner.  jag, you'll want to sort
through these and see which ones still apply and go with or against the
direction in which you intend strings evolve

Comment 7

[jag (Peter Annema)]

This got fixed in some way or other a long time ago.