NS_ConvertUTF8toUCS2::Init() treats aLength as chars, not bytes

RESOLVED WORKSFORME

Status

()

Core
String
P3
normal
RESOLVED WORKSFORME
18 years ago
9 years ago

People

(Reporter: Chris Waterson, Assigned: jag (Peter Annema))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
erik suggested that aLength should mean "the number of bytes in this string that 
you want to convert" as opposed to "the number of characters in this string that 
you want to convert". This would make it consistent with the way the Unicode 
encoders in I18n work.

Thought I'd put it into a bug for posterity's sake.
(Reporter)

Comment 1

18 years ago
Created attachment 9552 [details] [diff] [review]
proposed fix, which treats aLength as bytes count, not character count
(Reporter)

Comment 2

18 years ago
scc: this is eventually going to be code that will work via nsCharTraits. Can
you make the call wrt. whether or not you want aLength to mean characters or
bytes?
(Reporter)

Comment 3

18 years ago
scc, i'm giving this to you to decide what's right.
Assignee: waterson → scc

Updated

18 years ago
Status: NEW → ASSIGNED

Updated

18 years ago
QA Contact: leger → kandrot

Updated

18 years ago
Component: XPCOM → String
Target Milestone: --- → mozilla0.9.1

Updated

17 years ago
Depends on: 70090

Updated

17 years ago
No longer depends on: 70090

Updated

17 years ago
Blocks: 70090

Updated

17 years ago
Target Milestone: mozilla0.9.1 → mozilla0.9

Comment 4

17 years ago
moving out
Target Milestone: mozilla0.9 → mozilla0.9.2

Comment 5

17 years ago
re-targeting milestones, starting from a clean slate
Target Milestone: mozilla0.9.2 → ---

Comment 6

16 years ago
giving up ancient string bugs to the new string owner.  jag, you'll want to sort
through these and see which ones still apply and go with or against the
direction in which you intend strings evolve
Assignee: scc → jaggernaut
Status: ASSIGNED → NEW

Updated

12 years ago
QA Contact: kandrot → nobody
(Assignee)

Comment 7

9 years ago
This got fixed in some way or other a long time ago.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.