413783 - Params are not cleared for every call but instead are appended

Status: RESOLVED FIXED

(Core :: js-ctypes, defect)

Description

[Srirang G Doddihal (Brahmana)]

nsNativeMethod::Call() the parameter values are continuously appended which results in same behavior for multiple calls with different values.

Comment 1

[Srirang G Doddihal (Brahmana)]

Attachment: patch v0.1

Made the changes and it works absolutely fine for me. (On Windows)

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 298863 [details] [diff] [review]
patch v0.1

>Index: nsNativeMethod.cpp
>-NS_IMETHODIMP nsNativeMethod::Execute(JSContext* aContext, jsval* aValue)
>+NS_IMETHODIMP nsNativeMethod::Execute(JSContext* aContext, jsval* aValue, nsCOMArray<nsIVariant> aValues)

use nsCOMArray<nsIVariant> &aValues
so we don't copy the array

> 
>+    nsCOMArray<nsIVariant> paramValues;
>     for (PRUint32 i=0; i<argc; i++) {
>         nsCOMPtr<nsIVariant> varValue;
>         GET_ARG(varValue, argv[i]);
>-        mValues.AppendObject(varValue);
>+        paramValues.AppendObject(varValue);
>     }
> 
> #undef GET_ARG
> 
>-    rv = Execute(cx, vp);
>+    rv = Execute(cx, vp, paramValues);
> 
>     *_retval = PR_TRUE;
> 

paramValues -> values

>Index: nsNativeMethod.h
>-  NS_IMETHOD Execute(JSContext* aContext, jsval* aValue);
>+  NS_IMETHOD Execute(JSContext* aContext, jsval* aValue, nsCOMArray<nsIVariant> aValues);

use here too: nsCOMArray<nsIVariant> &aValues

good job. r=mfinkle

I can land this.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

landed