Closed
Bug 413797
Opened 17 years ago
Closed 17 years ago
Use generic FindOneBit on solaris instead of assemble code.
Categories
(Tamarin Graveyard :: Build Config, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: leon.sha, Assigned: leon.sha)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.22 KB,
patch
|
treilly
:
review+
|
Details | Diff | Splinter Review |
Currently the FindOneBit function in avmplus uses assembler code. For solaris use generic FindOneBit runction for now to avoid build problem.
Attachment #298880 -
Flags: review?(treilly)
|
||
Comment 2•17 years ago
|
||
Instead of SOLARIS should we just rely on the architecture ifdefs? Is the issue what we're trying to get sparc working or the compiler for solaris/x86 can't handlde the assembler?
The findonebit function in AvmCore.h is not used by any one. So remove this. Also use generic find one bit for solaris on x86 platform. Linux style assembler code can not be compiled bu sunstudio. Also the inline assembler code for sunstudio requires another .il file. For the current build system I don't know how to add this .il file.
Attachment #298880 -
Attachment is obsolete: true
Attachment #299730 -
Flags: review?(treilly)
Attachment #298880 -
Flags: review?(treilly)
|
|
||
Comment 4•17 years ago
|
||
Comment on attachment 299730 [details] [diff] [review] patch v2 Looks good! I love patches that remove more code than they add!
Attachment #299730 -
Flags: review?(treilly) → review+
Checked in. Thanks Tommy.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Comment 6•15 years ago
|
||
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•