413817 - Clearing history using 'Clear Private Data' doesn't work when privacy.item.offlineApps isn't set

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Hussam Al-Tayeb]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008012406 Firefox/3.0b3pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008012406 Firefox/3.0b3pre

Clearing history using 'Clear Private Data' doesn't work. The browsing history and location bar history stays there.
Plus, this error shows in error console when I press 'Clear Private Data':

Error: uncaught exception: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://browser/content/sanitize.js :: anonymous :: line 37"  data: no]




Reproducible: Always

Comment 1

[Hussam Al-Tayeb]

I found the cause.
The bug happens only when "privacy.item.offlineApps" isn't set in prefs.js
setting it to either true or false fixes the issue.

Can someone please take a look?

Comment 2

[Marco Bonardo [:mak]]

Attachment: intercept exception, pref false if pref not existant

i'm not sure if that can happen, or is caused by a wrong pref.js file... 

however i doubt this is a places bug, should go into core (but what leaf? Networking:Cache?)

Comment 3

[John P Baker]

> ... or is caused by a wrong pref.js file... 

this part is probably blocking bug 398478

Comment 4

[Dave Camp (:dcamp)]

Attachment: add privacy.item.offlineApps to firefox.js

Bug 398478 should have added this pref.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 299001 [details] [diff] [review]
add privacy.item.offlineApps to firefox.js

a=beltzner for 1.9

Comment 6

[Dave Camp (:dcamp)]

Checking in firefox.js;
/cvsroot/mozilla/browser/app/profile/firefox.js,v  <--  firefox.js
new revision: 1.258; previous revision: 1.257
done

Comment 7

[Kay Abendroth]

Works for me.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008051202 Firefox/3.0

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv