413826 - When autofilling login info, the username is now selected but not focused

Status: RESOLVED FIXED

(Camino Graveyard :: OS Integration, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

STR:

1. Visit a site where you have saved login information but aren't logged in (e.g., visit http://wiki.caminobrowser.org/ and then click on the "log in/create account" link)
2. Let Camino autofill your username/password
3. Press the delete key

AR: You go back one page in history

ER: Either a) the prefilled username is deleted or b) after step 2, nothing is selected at all

In 1.6b2, the username was not selected when it was autofilled.  In the era of multiple accounts, it might make sense for the username to be selected so the user can quickly type or delete to start selecting an alternate account, but in that case focus needs to end up in that field.

Note that this does work as expected with Gmail/Google login; I suspect they're doing some extra JS work to help us out.

(Also note that this could possibly be a Core regression during the past 5 days instead of our change; I haven't checked that possibility yet, but it seems less likely than our own changes.)

Comment 1

[Bryan Atwood]

Attachment: patch

Thanks for finding these.  I'm trying to be pro-active in fixing them since I'll be on vacation starting next week.  Hopefully we don't run across any show-stoppers.

Comment 2

[Stuart Morgan]

Comment on attachment 298946 [details] [diff] [review]
patch

Since I don't think we want to muck with initial focus on pages, this is probably the best option.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on the trunk and MOZILLA_1_8_BRANCH.  Thanks for getting these so quickly, Bryan!