413844 - F6 doesn't switch between content and location bar anymore

Status: VERIFIED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Arjan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012404 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012404 Minefield/3.0b3pre

Since some time now, pressing F6 will not focus the URI in the location bar anymore. It will instead focus around Larry (pressing enter will show him). 

As I find F6 much less intensive than alt+d, I would like to return to the old-style

Reproducible: Always

Steps to Reproduce:
1. Focus the webpage
2. Press F6
3. 
Actual Results:  
Larry focussed

Expected Results:  
URI in location bar selected

Comment 1

[Simon Bünzli]

This comes from making the Identity indicator keyboard accessible - now it's the first tabbable item in the main browser frame, which is what gets the focus through F6. This could thus be WORKSFORME, although it'll feel like a regression to many users nonetheless.

Comment 2

[Arjan]

I'm all for keyboard a11y, but can't the taborder by changed so the location bar gets the focus first?

Comment 3

[Marco Zehe (:MarcoZ)]

This is a result of fix for bug 407359. Aaron, I think having Larry in the tab order before the location bar is good, but could we somehow force the focus to go to the Location bar instead?

Comment 4

[Aaron Leventhal]

Attachment: Add identity button to tab order only when location bar has focus. Remove from tab order when location bar blurred.

Unfortunately the logic for F6 is hardcoded into nsEventStateManager::ShiftFocusByDocument(). It would be very ugly to specially code for this situation there.

This solution seems to work perfectly well. Once you focus the location bar, either by tabbing or using Ctrl+L/Alt+D, you can shift+Tab to the identity popup. This means that if you shift+Tab out of the document you will now end up at the location bar instead of the identity popup, but that's arguably good. It also means that if you click on the identity button and then hit escape, your focus goes into the location bar -- a behavior I was actually trying to achieve before. So all around I think this works well, although the code needs a comment since it's a bit unexpected.

Comment 5

[Asaf Romano (gone)]

Is it safe to have an element focused when it's set to be not focusable, ESM-code-wise for example?

Comment 6

[Aaron Leventhal]

(In reply to comment #5)
> Is it safe to have an element focused when it's set to be not focusable,
> ESM-code-wise for example?

Let's ask Mats if he knows of anything. I can't think of anything unsafe about it. 

Comment 7

[Mats Palmgren (inactive)]

I don't see any problem with that, it should work fine.

Comment 8

[Asaf Romano (gone)]

Comment on attachment 299625 [details] [diff] [review]
Add identity button to tab order only when location bar has focus. Remove from tab order when location bar blurred.

ok then.

Comment 9

[Damon Sicore (:damons)]

Comment on attachment 299625 [details] [diff] [review]
Add identity button to tab order only when location bar has focus. Remove from tab order when location bar blurred.

a1.9+=damons

Comment 10

[Simon Bünzli]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008020104
-> VERIFIED

Comment 11

[heraldo]

Fails for me in Firefox 4 beta6, F6 switches focus between page and tab instead.

Comment 12

[Neil Deakin]

That's correct behaviour when one has tabs on top, as the tab is the first focusable item in the window.