Closed Bug 413854 Opened 16 years ago Closed 16 years ago

Wrong rendering of -moz-appearance: listbox and -moz-appearance: treeview

Categories

(Core :: Widget: Gtk, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta3

People

(Reporter: frnchfrgg, Assigned: frnchfrgg)

Details

Attachments

(3 files, 1 obsolete file)

It may not be visible in every theme, but on thinice at least there's a difference between native treeviews or lists and -moz-appearance: listbox rendering.
See attached screenshot
I think it's really cheap to correct, so we should afford it.
Assignee: nobody → frnchfrgg-mozbugs
Status: NEW → ASSIGNED
Attachment #299047 - Flags: superreview?(roc)
Attachment #299047 - Flags: review?(ventnor.bugzilla)
Attachment #299047 - Flags: review?(ventnor.bugzilla) → review+
Comment on attachment 299047 [details] [diff] [review]
Correct -moz-appearance: treeview; rendering [v1]

call x/y something more specific like xThickness/yThickness?
Attachment #299047 - Flags: superreview?(roc) → superreview+
Carried review from previous patch. This is really cheap and corrects some native theming glitches.
Attachment #299047 - Attachment is obsolete: true
Attachment #299151 - Flags: superreview+
Attachment #299151 - Flags: review+
Attachment #299151 - Flags: approval1.9?
Comment on attachment 299151 [details] [diff] [review]
Correct -moz-appearance: treeview; rendering [v1.1]

a=beltzner for 1.9
Attachment #299151 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.71; previous revision: 1.70
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
We really need to use a GtkScrolledWindow and not the TreeView to draw the shadow, or else we sometimes get the wrong border colors (on thin ice, the blue tint of active buttons is wrongly used, for instance). Patch following.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
See comment from bug reopening
Attachment #301182 - Flags: superreview?(roc)
Attachment #301182 - Flags: review?(ventnor.bugzilla)
Attachment #301182 - Flags: review?(ventnor.bugzilla) → review+
Attachment #301182 - Flags: superreview?(roc) → superreview+
Attachment #301182 - Flags: approval1.9?
Comment on attachment 301182 [details] [diff] [review]
Use a real scrolled window to draw the inset shadow [v1]

a1.9+=damons
Attachment #301182 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.77; previous revision: 1.76
done
Status: REOPENED → RESOLVED
Closed: 16 years ago16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: