Wrong rendering of -moz-appearance: listbox and -moz-appearance: treeview

RESOLVED FIXED in mozilla1.9beta3

Status

()

Core
Widget: Gtk
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Julien "_FrnchFrgg_" RIVAUD, Assigned: Julien "_FrnchFrgg_" RIVAUD)

Tracking

Trunk
mozilla1.9beta3
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

11 years ago
Created attachment 298959 [details]
Differences between Firefox and Gimp rendering of a listbox/treeview

It may not be visible in every theme, but on thinice at least there's a difference between native treeviews or lists and -moz-appearance: listbox rendering.
See attached screenshot
(Assignee)

Comment 1

11 years ago
Created attachment 299047 [details] [diff] [review]
Correct -moz-appearance: treeview; rendering [v1]

I think it's really cheap to correct, so we should afford it.
Assignee: nobody → frnchfrgg-mozbugs
Status: NEW → ASSIGNED
Attachment #299047 - Flags: superreview?(roc)
Attachment #299047 - Flags: review?(ventnor.bugzilla)

Updated

11 years ago
Attachment #299047 - Flags: review?(ventnor.bugzilla) → review+
Comment on attachment 299047 [details] [diff] [review]
Correct -moz-appearance: treeview; rendering [v1]

call x/y something more specific like xThickness/yThickness?
Attachment #299047 - Flags: superreview?(roc) → superreview+
(Assignee)

Comment 3

11 years ago
Created attachment 299151 [details] [diff] [review]
Correct -moz-appearance: treeview; rendering [v1.1]

Carried review from previous patch. This is really cheap and corrects some native theming glitches.
Attachment #299047 - Attachment is obsolete: true
Attachment #299151 - Flags: superreview+
Attachment #299151 - Flags: review+
Attachment #299151 - Flags: approval1.9?
Comment on attachment 299151 [details] [diff] [review]
Correct -moz-appearance: treeview; rendering [v1.1]

a=beltzner for 1.9
Attachment #299151 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.71; previous revision: 1.70
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
(Assignee)

Comment 6

11 years ago
We really need to use a GtkScrolledWindow and not the TreeView to draw the shadow, or else we sometimes get the wrong border colors (on thin ice, the blue tint of active buttons is wrongly used, for instance). Patch following.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

11 years ago
Created attachment 301182 [details] [diff] [review]
Use a real scrolled window to draw the inset shadow [v1]

See comment from bug reopening
Attachment #301182 - Flags: superreview?(roc)
Attachment #301182 - Flags: review?(ventnor.bugzilla)

Updated

11 years ago
Attachment #301182 - Flags: review?(ventnor.bugzilla) → review+
Attachment #301182 - Flags: superreview?(roc) → superreview+
Attachment #301182 - Flags: approval1.9?
Comment on attachment 301182 [details] [diff] [review]
Use a real scrolled window to draw the inset shadow [v1]

a1.9+=damons
Attachment #301182 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.77; previous revision: 1.76
done
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.