413954 - nsHandlerService.store fails to remove applications

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Florian Quèze [:florian]]

Attachment: patch v1

In _storePossibleHandlers, the method _removeTarget is called with 3 arguments, but it expects only 2.

The patch adds a _removeResourceAssertion method that removes a specific target.
It also renames _addResourceTarget to _addResourceAssertion, per Myk's suggestion.

Thanks for the help on this Myk!

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 299122 [details] [diff] [review]
patch v1

Looks great, r=myk

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 299122 [details] [diff] [review]
patch v1

>Index: uriloader/exthandler/nsHandlerService.js

>   /**
>+   * Remove a property of an RDF source to a resource target.
>+   *
>+   * @param sourceURI   {string} the URI of the source
>+   * @param propertyURI {string} the URI of the property
>+   * @param targetURI   {string} the URI of the target
>+   */
>+  _removeResourceAssertion: function HS__removeResourceAssertion(sourceURI,
>+                                                                 propertyURI,
>+                                                                 targetURI) {

Erm, just one thing: the description of this method should be:

  Remove an assertion with a resource target.

Comment 3

[Boris Zbarsky [:bzbarsky]]

I'm sorry, I can't review this.  I neither understand what the original code is doing, nor what this patch is doing.

dmose would make a far better sr for this stuff, no?

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 299122 [details] [diff] [review]
patch v1

sr=dmose

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 299122 [details] [diff] [review]
patch v1

a=beltzner for 1.9

Comment 6

[Florian Quèze [:florian]]

Checking in uriloader/exthandler/nsHandlerService.js;
/cvsroot/mozilla/uriloader/exthandler/nsHandlerService.js,v  <--  nsHandlerService.js
new revision: 1.18; previous revision: 1.17
done