Add explicit message if preference isn't set for about:crashes

RESOLVED FIXED in mozilla1.9beta3

Status

()

Toolkit
Crash Reporting
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

({late-l10n})

Trunk
mozilla1.9beta3
late-l10n
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
From bug 411490, if the url pref isn't set then display an explicit message:

"Crash Report listing isn't configured in this application"

"The x.y preference needs to be set to the correct crash report
server for this application"

Are possibilities.
(Assignee)

Comment 1

11 years ago
This will require a string and I'm not going to get to it till after the freeze
Blocks: 411490
Keywords: late-l10n
(Assignee)

Comment 2

11 years ago
Created attachment 299574 [details] [diff] [review]
patch rev 1

This adds the explicit message if the preference isn't set:

"This application has not been configured to display crash reports. The preference breakpad.reportURL must be set."
Attachment #299574 - Flags: review?(mano)
(Assignee)

Comment 4

11 years ago
Comment on attachment 299574 [details] [diff] [review]
patch rev 1

Seeking approval to land. This minor modification makes the about:crashes page behave sensibly on applications that aren't configured for it.
Attachment #299574 - Flags: approval1.9?

Updated

11 years ago
Attachment #299574 - Flags: approval1.9? → approval1.9+
Comment on attachment 299574 [details] [diff] [review]
patch rev 1

>>+<!ENTITY noConfig.label             "This application has not been configured to display crash reports. The preference <code>breakpad.reportURL</code> must be set.">

Without giving any indication of what to set it to, I don't think the latter half of this string is all that helpful and would recommend we drop it.

I'm also not very convinced we need this at all, but schrep's given his a, so feel free!
Attachment #299574 - Flags: ui-review+
(Assignee)

Comment 6

11 years ago
Landed as-is per bz's request.

Checking in toolkit/crashreporter/content/crashes.xhtml;
/cvsroot/mozilla/toolkit/crashreporter/content/crashes.xhtml,v  <--  crashes.xhtml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/locales/en-US/crashreporter/crashes.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/crashreporter/crashes.dtd,v  <--  crashes.dtd
new revision: 1.2; previous revision: 1.1
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Target Milestone: --- → mozilla1.9 M11
You need to log in before you can comment on or make changes to this bug.