414240 - Clean-up nsDownloadManager::GetRetentionBehavior()

Status: UNCONFIRMED

(Toolkit :: Downloads API, defect)

Description

[Graeme McCutcheon [:graememcc]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11

nsDownloadManager::GetRetentionBehavior() should be cleaned up in a manner consistent with nsDownloadManager::GetQuitBehavior().

In particular, a javadoc style comment should be added to nsDownloadManager.h, it should check for nonsensical values in the preference and return a sensible default, and an enum should be defined to make clear the meanings of the possible return values. These values should be used by any callers of GetRetentionBehavior.


Reproducible: Always

Steps to Reproduce:
1.
2.
3.