414272 - Local file favicons in History go generic on relaunch

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: History, defect)

Description

[Lisa Thompson]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.12pre) Gecko/20080118 Camino/1.6b2 (like Firefox/2.0.0.12pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.12pre) Gecko/20080118 Camino/1.6b2 (like Firefox/2.0.0.12pre)

If you open a local file in Camino, it appears in the History menu and about:history with a favicon that looks the same as its Finder icon. But when Camino is relaunched, any un-bookmarked local files in the History menu have the generic blue globe as favicon (about:history still shows the file's Finder icon).


Reproducible: Always

Steps to Reproduce:
1. Open a local file in Camino, a .html or image file, say, but one that isn't in your bookmarks.
2. Pull down the History menu and notice that the file's favicon is the same as its Finder icon. 
3.Quit and relaunch Camino
4. Pull down the History menu and notice that the file's favicon has reverted to the generic blue globe.
Actual Results:  
The file's favicon has reverted to the generic blue globe.

Expected Results:  
The file's favicon should be the same as the one used in the Finder for that file (as it is in about:history, and in bookmarks).

Local file favicons also have issues in bookmarks: if a local file is bookmarked in a folder on the Bookmark Bar, when you first click on the folder after a relaunch, the menu shows the generic green ribbon as the files’ favicon. Click on the folder again immediately and the file's Finder icon shows up as favicon.

Comment 1

[Chris Lawson (gone)]

See also bug 346061 comment 16 et seq. This may also be related to bug 357516.

cl

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Confirming; I see this, and if it happens to be a dupe, we can dupe it at some later date.

Comment 3

[Christopher Henderson]

Attachment: Fix v1.0

Now the SiteIconProvider always tells the sharedSiteIconCache to cache the favicons to disk, no matter their provenance.

Comment 4

[Stuart Morgan]

Comment on attachment 336822 [details] [diff] [review]
Fix v1.0

Why would we want to do this? It's already available locally, so caching it locally again just means that we use more space and can serve stale icons.

We should handle lookup of local files differently, not storage.

Comment 5

[Christopher Henderson]

Comment on attachment 336822 [details] [diff] [review]
Fix v1.0

Following comments, I'm obsoleting this bug. I will tackle this bug with a different approach.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Specifically, bug 391864 stopped keeping disk cache copies of file: and about: icons, which is what "broke" this.

I suspect that bug also caused bug 425878--which drives me so crazy that I've spent more hours poking it than anything else I've tried and failed to fix in Camino ;)

There's a bit more debugging info in bug 425878, but I don't know if it's useful at all :P

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #6)
> I suspect that bug also caused bug 425878

Nope.

Comment 8

[Takanori MATSUURA]

This bug lies at rest in the graveyard.