414284 - Bug edit page is bad for changing components

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Reed Loden [:reed]]

The new bug edit page is a nightmare for triagers... Instead of just clicking one radio button for "Reassign bug to default assignee and QA contact, and add Default CC of selected component", triagers now have to click (edit) next to the assignee name, check the "Reset Assignee to default" box, click (edit) next to the QA contact, check the "Reset QA Contact to default" box, and then go all the way to the bottom and hit Commit. That's unacceptable...

Also, what happened to "add Default CC of selected component" when you change the component? When does that happen with the new bug edit form (if at all)?

Comment 1

[Frédéric Buclin]

Probably the intermediate page when moving the bug into another product should have a checkbox (crossed by default) which lets you reassign the bug to the default assignee and QA contact. About moving into another component of the same product, JS could cross the "reset to the default assignee/QA contact" checkboxes.

Comment 2

[Frédéric Buclin]

Oh, and note that in Bugzilla 3.0.x, moving the bug to another product or component doesn't select the "reassign to the default..." radio button, so that's not a regression in the new UI.

Comment 3

[Reed Loden [:reed]]

(In reply to comment #1)
> Probably the intermediate page when moving the bug into another product should
> have a checkbox (crossed by default) which lets you reassign the bug to the
> default assignee and QA contact.

Bug 320700.

(In reply to comment #2)
> Oh, and note that in Bugzilla 3.0.x, moving the bug to another product or
> component doesn't select the "reassign to the default..." radio button, so
> that's not a regression in the new UI.

I never said it was. However, you're adding three more steps than 3.0.x had.

Comment 4

[Max Kanat-Alexander]

The solution here should be that if you change the component, the two boxes automatically get checked (which also means that they both go into "edit" mode). Some attention should be called to this, perhaps by an inoffensive animation or a brief flash of color.

Note that this is not a regression because this isn't any different than how the old edit form behaved (the upstream one, not the bmo one), except that you do have to click edit.

I agree that it would be very very nice to do this.

Comment 5

[Guy Pyrzak]

I'm happy to take this one on after i move the knob up to the top of the page.

However, The problem here is that there are some workflows that isn't being supported, specifically for triagers:

1. Change Component, Reassign bug to default assignee, qa contact and add Default CC of selected component (what reed described). 
---> This could be a checkbox next to Component when you edit it. (that seems to make the MOST sense and also degrades well). Is this still supported?
2. Assign to me. (something I find myself doing)

Are there more?

Comment 6

[Guy Pyrzak]

ok I thought about it. without the JS this stops being a "nightmare" so there are no worries about degrading. I'll make yet another hyperlink that when you click it. It checks the Reassign bug to default assignee, QA contact.

add default CC of selected component might also be doable via JS. 

And if I'm feeling fancy, i might make it undoable via a hyperlink. 

The degrade is, you get to do it by hand, since it's just making triager's life's easier.

Comment 7

[Phil Ringnalda (:philor)]

I haven't had time yet to see which of these don't work well on -tip, but what I do most (in descending order) is:

1. Change Product, reassign to defaults
2. Change Component, reassign to defaults
3. Change Component, only reassign to default QA
4. Change Product, only reassign to default QA
5. Reassign to defaults in the current Product & Component
6. Reassign to default QA in the current Product & Component

Comment 8

[Guy Pyrzak]

Attachment: Patch v1

Fix for the concern. If you edit either Product or Component the Assignee and the QA contact becomes editable. I could add CC but i don't see the point since the default CC's for the component are automatically added just by changing the component anyway.

Comment 9

[Frédéric Buclin]

Are the "reset to default" checkboxes crossed by default with this patch?

Comment 10

[Guy Pyrzak]

no. Based on the use cases that were listed above I didn't want to do that without further discussion. It's very simple to make that part of this patch though. This is basically a UE thing and i didn't feel comfortable doing too much. 

I could add a hyperlink that appears to let you do that in one click. 

The reason why i don't want to do it automatically is because there is nothing in the UI that indicates that it will also reassign the default assignee and qa contact. In gerenal a system that does "smart" things without letting a user know is usually disconcerting unless it is what happens almost every time. I'm not sure if that is the case when it comes to changing the Product & Component, but that is due to a lack of user research.

If someone from the UE team would like to study this behavior more closely that would be good. I don't have the time to fix all my bugs and do a study as well.

Comment 11

[Frédéric Buclin]

This bug is a dupe of bug 92549.

Comment 12

[Max Kanat-Alexander]

Comment on attachment 299711 [details] [diff] [review]
Patch v1

Right now bmo automatically switches the knob to reset the assignee and QA Contact, and it's been useful at least for me. Now that there's two checkboxes to check, I think this is going to get messed up in the normal use case if we don't automatically check the boxes.

Comment 13

[Guy Pyrzak]

ok, checking it is trivial. I'll make those changes and resubmit.

Comment 14

[Guy Pyrzak]

Attachment: Patch v2

Comment 15

[Max Kanat-Alexander]

Comment on attachment 300555 [details] [diff] [review]
Patch v2

Yes, I like this, and it works. :-)

Comment 16

[Max Kanat-Alexander]

I guess we'll see if people freak out when we test this on bmo at some point in the future. :-) I think it'll be good, though. The bold makes it very apparent what's happening, probably even more apparent than the magic knob-change was before.

Checking in js/field.js;
/cvsroot/mozilla/webtools/bugzilla/js/field.js,v  <--  field.js
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.113; previous revision: 1.112
done