Closed Bug 414374 Opened 15 years ago Closed 15 years ago

Make debug mailnews builds nonstatic by default


(Firefox Build System :: General, enhancement)

Not set


(Not tracked)



(Reporter: neil, Assigned: neil)



(1 file)

...just as debug browser builds are nonlibxul by default.
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Attachment #299763 - Flags: superreview?(bienvenu)
Attachment #299763 - Flags: review?(ted.mielczarek)
My fear about this is that when people add components, they'll forget the static build and break tinderbox. I think mailnews probably adds components more frequently than libxul does.

It would be nice if each developer could decide what they wanted with a .mozconfig option - that's not possible now, is it?

I'm not removing that facility, I just would like to change the default.
Comment on attachment 299763 [details] [diff] [review]
Proposed patch

This should be fine, we do the same thing with libxul, since it's painful to build debug.  We trust that developers will watch the tinderbox for bustage if they broke something in libxul only.
Attachment #299763 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 299763 [details] [diff] [review]
Proposed patch

OK - this should be announced pretty widely, and it would be really nice as part of that announcement to tell people how to change their mozconfig to keep the previous behavior.
Attachment #299763 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 299763 [details] [diff] [review]
Proposed patch

Build config change that only affects SeaMonkey and Thunderbird debug builds.
Attachment #299763 - Flags: approval1.9?
Comment on attachment 299763 [details] [diff] [review]
Proposed patch

What exactly are you going to do to address David's concerns above? Let's make sure it happens. 

Attachment #299763 - Flags: approval1.9? → approval1.9+
(In reply to comment #7)
>What exactly are you going to do to address David's concerns above?
I've topic'd #maildev and announced in three newsgroups.
Need to remember to check this in after beta freeze...
Keywords: checkin-needed
Fix checked in.
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.