Closed
Bug 414374
Opened 17 years ago
Closed 17 years ago
Make debug mailnews builds nonstatic by default
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
1.45 KB,
patch
|
ted
:
review+
Bienvenu
:
superreview+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
...just as debug browser builds are nonlibxul by default.
Assignee | ||
Comment 1•17 years ago
|
||
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #299763 -
Flags: superreview?(bienvenu)
Attachment #299763 -
Flags: review?(ted.mielczarek)
Comment 2•17 years ago
|
||
My fear about this is that when people add components, they'll forget the static build and break tinderbox. I think mailnews probably adds components more frequently than libxul does.
It would be nice if each developer could decide what they wanted with a .mozconfig option - that's not possible now, is it?
Assignee | ||
Comment 3•17 years ago
|
||
I'm not removing that facility, I just would like to change the default.
Comment 4•17 years ago
|
||
Comment on attachment 299763 [details] [diff] [review]
Proposed patch
This should be fine, we do the same thing with libxul, since it's painful to build debug. We trust that developers will watch the tinderbox for bustage if they broke something in libxul only.
Attachment #299763 -
Flags: review?(ted.mielczarek) → review+
Comment 5•17 years ago
|
||
Comment on attachment 299763 [details] [diff] [review]
Proposed patch
OK - this should be announced pretty widely, and it would be really nice as part of that announcement to tell people how to change their mozconfig to keep the previous behavior.
Attachment #299763 -
Flags: superreview?(bienvenu) → superreview+
Assignee | ||
Comment 6•17 years ago
|
||
Comment on attachment 299763 [details] [diff] [review]
Proposed patch
Build config change that only affects SeaMonkey and Thunderbird debug builds.
Attachment #299763 -
Flags: approval1.9?
Comment 7•17 years ago
|
||
Comment on attachment 299763 [details] [diff] [review]
Proposed patch
What exactly are you going to do to address David's concerns above? Let's make sure it happens.
a1.9+=damons
Attachment #299763 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 8•17 years ago
|
||
(In reply to comment #7)
>What exactly are you going to do to address David's concerns above?
I've topic'd #maildev and announced in three newsgroups.
Assignee | ||
Comment 9•17 years ago
|
||
Need to remember to check this in after beta freeze...
Keywords: checkin-needed
Assignee | ||
Comment 10•17 years ago
|
||
Fix checked in.
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•