41443 - "frame info" and "page info" in the context menu needs to be implemented

Status: VERIFIED FIXED

(SeaMonkey :: Page Info, defect, P5)

Description

[Marko Macek]

"frame info" needs to show page info window (where a full frame hierarchy should
be shown like in 4.x)

This is a most useful 4.x feature.

Comment 1

[Asa Dotzler [:asa]]

Sorry for the spam.  New QA Contact for Browser General.  Thanks for your help
Joseph (good luck with the new job) and welcome aboard Doron Rosenberg

Comment 2

[Doron Rosenberg (IBM)]

--> html frames

Comment 3

[Eric Pollmann]

--> Context menu folks.  Let me know if I can help with this.  Thanks!

Comment 4

[sairuh (rarely reading bugmail)]

over to me --but if anyone wants to take it, feel free :-). also noticed that
"view page info" (for non-frame pages) is missing (w/respect to 4.x).

Comment 5

[Jay Patel [:jay]]

Putting on [NEED INFO] radar. Are "frame info" and "page info" on the exception 
features list?

Comment 6

[sol]

Not sure if these are on the exception features list, but I don't consider 
access to page info or frame info from a context menu to be a beta 2 stopper.

Comment 7

[johng]

agreed, not a nsbeta2 stopper.

nsbeta3 nominee

Comment 8

[Jay Patel [:jay]]

Putting on [nsbeta2-] radar. Not critical to beta2. 

Comment 9

[verah (gone)]

Nav triage team: minus, polish, reassigning to Mcafee

Comment 10

[sairuh (rarely reading bugmail)]

lack of Frame Info period blocks 52730 (tracking).

Comment 11

[Blake Ross]

is frame info even implemented?  If not, we need a new bug on that first.

Comment 12

[sairuh (rarely reading bugmail)]

cannot find an existing bug that covers Frame Info implementation --feel free to
create one if i don't get to it in the next coupla minutes (going thru my
bugmail, so it might be a bit...).

Comment 13

[Raghu Sakleshpur]

Adding sun tracking string

Comment 14

[André Langhorst]

It would be smart to extend "Page Info" to contain the "framed" structure of a
page with clickable items to select a specific Frame

eg.
Frames on this Page
--------------------
Header -> /kljsdf/text.html
Footer -> /asdfss/set.php

Selected Frame: Header
-----------------------
Images in this Frame...
Forms in this Frame...

Then we would not need an additional item "Frame Info" and it would also be more
comfortable...

Comment 15

[Matthew T (active 1999-2002)]

André, that is covered in the spec
<http://critique.net.nz/project/mozilla/general/component/info/> for bug 52730, 
which is the parent bug of this one.

Comment 16

[Marcia Knous [:marcia]]

Netscape Nav triage team: this is a Netscape beta stopper.  Assigning priority 
P3.

Comment 17

[Paul Chen]

Futured and marked p5 to make room on McAfee's plate for 44733

Comment 18

[sairuh (rarely reading bugmail)]

just wondering: should this then be marked nsbeta1-...?

Comment 19

[Matthew Wilson]

Attachment: Patch to add Page Info and Frame Info to context menu. (I take Frame Info to mean Page Info for the active frame.)

Comment 20

[Chris McAfee]

Can we have viewFrameInfo also use BrowserPageInfo(), and pass
that last argument in?  viewInfo would then call BrowserPageInfo(null)
or something like that.

patch looks good, tested it on linux & works, good work!

Comment 21

[Matthew Wilson]

Attachment: Revised patch

Comment 22

[Ben Goodger (use ben at mozilla dot org for email)]

if (window.arguments && window.arguments[0]) seems kinda wonky to me. I think 
arguments will always be defined on window, so checking for it before accessing 
slot 0 doesn't get you anything. What you really want to be checking is to see 
if the length >= 1, i.e. if (window.arguments.length && window.arguments[0])

with that, a=[e-mail]

Comment 23

[Chris McAfee]

fixed checked in, thanks to matthew for most of the work here.

Comment 24

[sairuh (rarely reading bugmail)]

vrfy fixed using 2001.05.25.10 comm bits on linux, and 2001.05.24.0x comm bits
on mac and winnt.

Comment 25

[Blake Ross]

This fix was incorrect.  Calling functions that live in browser files from a 
global context menu is unacceptable.

Comment 26

[Matthew Wilson]

nsContextMenu.js has other references to navigator-only files.

http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/nsContextMenu.js#27

'This JavaScript "class" is used to implement the browser's content-area
context menu.                                                                  
     

For usage, see references to this class in navigator.xul.
Currently, this code is relatively useless for any other purpose.  In the
longer term, this code will be restructured to make it more reusable."'