414431 - [proto] Bookmark toolbar bookmarks are clipped at their base on hover.

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot; look at its base and see the clipping

Bookmark toolbar bookmarks are clipped at their base on hover.

See screenshot.

Comment 1

[Asa Dotzler [:asa]]

This is pretty ugly and in a primary piece of UI. Can we get this blocking 3?

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Is this still an issue in the most recent version of the Mac theme?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yes. But perhaps the feeling that the bottom border is clipped is raised by the two white pixels which appear on the left and right site. See the attachment on this bug. If both wouldn't appear it will be ok IMO.

Comment 4

[Asa Dotzler [:asa]]

Still a problem with today's nightly and it really does look busted

Comment 5

[Pierre de La Morinerie]

(In reply to comment #3)
> Yes. But perhaps the feeling that the bottom border is clipped is raised by the
> two white pixels which appear on the left and right site. See the attachment on
> this bug. If both wouldn't appear it will be ok IMO.
> 
The two white pixels seem to be a part of the normal style — some kind of reflexion at the bottom of the sunken metal. Plus if you click and hold on the bookmark, the darker sunken look that appears has the bottom line one pixel below the hovered state — i.e. at the right place.

By the way, this glitch is pretty noticable (I noticed it quickly after downloading my first FF3 beta) and ugly...
:: go digging into the theme code ::

Comment 6

[Pierre de La Morinerie]

Attachment: Try at picture edit, doesn't look so well

I looked into the chrome for this issue. It appears that the css picture *are* correctly positioned, and have the correct height : the pictures are correct, but the design itself are wrong. Apparently, the theme was *intended* to be like this, but obviously it doesn't fit.

I edited the pictures to extend the gradient to the bottom, but it doesn't look that well : we can't really see the bottom of the sunken effect (see attachment). As it is a graphical issue and not a coding bug, I suggest referring to the creator(s)/maintainer(s) of the Theme : maybe they can provide a better version of this hover effect.

Comment 7

[Stephen Horlander [:shorlander]]

This should be fixed.

Comment 8

[Asa Dotzler [:asa]]

indeed. and has been for a while, I believe. 

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED for me using the default Mac theme on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008040804 Minefield/3.0pre