Closed Bug 414549 Opened 15 years ago Closed 15 years ago

bad index in nested loops in refreshVisibleSection hangs on infinite loop

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED
Firefox 3 beta3

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: hang)

Attachments

(1 file)

While working on Bug 402486 i ended up into a js hang, the script was looping continuously into restore selection loop of _refreshVisibleSection (treeView.js)

we are doing something like this there
for (var i = 0; i < previouslySelectedNodes.length; i++) {
  [...]
  for (i=0; i < newElements.length && index == -1; i++) {
  [...]
  }
}

if i'm not wrong *i* should be something else into the nested loops
Attachment #299995 - Flags: review?(mano)
Assignee: nobody → mak77
Blocks: 402486
Comment on attachment 299995 [details] [diff] [review]
fix nested loops indexes

thanks!(!!!)

r=mano.
Attachment #299995 - Flags: review?(mano) → review+
Flags: blocking-firefox3?
Flags: blocking-firefox3? → blocking-firefox3+
mozilla/browser/components/places/content/treeView.js 1.34
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta3
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.