414549 - bad index in nested loops in refreshVisibleSection hangs on infinite loop

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

Attachment: fix nested loops indexes

While working on Bug 402486 i ended up into a js hang, the script was looping continuously into restore selection loop of _refreshVisibleSection (treeView.js)

we are doing something like this there
for (var i = 0; i < previouslySelectedNodes.length; i++) {
  [...]
  for (i=0; i < newElements.length && index == -1; i++) {
  [...]
  }
}

if i'm not wrong *i* should be something else into the nested loops

Comment 1

[Asaf Romano (gone)]

Comment on attachment 299995 [details] [diff] [review]
fix nested loops indexes

thanks!(!!!)

r=mano.

Comment 2

[Asaf Romano (gone)]

mozilla/browser/components/places/content/treeView.js 1.34

Comment 3

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv