Closed
Bug 414551
Opened 18 years ago
Closed 17 years ago
gCallbacksEnabled in prefapi.cpp is unused and should be killed
Categories
(Core :: Preferences: Backend, defect)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: asqueella, Assigned: Swatinem)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
1.83 KB,
patch
|
benjamin
:
review+
benjamin
:
superreview+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/seamonkey/source/modules/libpref/src/prefapi.cpp
http://mxr.mozilla.org/seamonkey/search?string=gCallbacksEnabled
Darin wrote about this in bug 219479 comment 9, but the var was never killed.
| Reporter | ||
Updated•18 years ago
|
Whiteboard: [good first bug]
| Assignee | ||
Comment 1•17 years ago
|
||
Small patch that does the job.
Assignee: nobody → arpad.borsos
Status: NEW → ASSIGNED
Attachment #335498 -
Flags: review?(darin.moz)
| Assignee | ||
Comment 2•17 years ago
|
||
I didn't notice this has interfered with my profilesharing patch.
Updated patch.
Attachment #335498 -
Attachment is obsolete: true
Attachment #351531 -
Flags: superreview?(benjamin)
Attachment #351531 -
Flags: review?(benjamin)
Attachment #335498 -
Flags: review?(darin.moz)
Updated•17 years ago
|
Attachment #351531 -
Flags: superreview?(benjamin)
Attachment #351531 -
Flags: superreview+
Attachment #351531 -
Flags: review?(benjamin)
Attachment #351531 -
Flags: review+
| Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
Comment 3•17 years ago
|
||
Comment on attachment 351531 [details] [diff] [review]
updated
[Checkin: Comment 3]
http://hg.mozilla.org/mozilla-central/rev/407791718438
Attachment #351531 -
Attachment description: updated → updated
[Checkin: Comment 3]
Comment 4•17 years ago
|
||
(Fwiw, I'd like to see this into 1.9.1 too.)
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [good first bug]
Target Milestone: --- → mozilla1.9.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•