Closed
Bug 414571
Opened 17 years ago
Closed 16 years ago
Update Firefox default theme icon, version and preview for Final Release of 3.0
Categories
(Firefox :: Theme, defect, P2)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 3
People
(Reporter: u88484, Assigned: faaborg)
References
Details
(Keywords: polish)
Attachments
(5 files, 2 obsolete files)
9.08 KB,
image/png
|
beltzner
:
ui-review+
beltzner
:
approval1.9+
|
Details |
36.70 KB,
image/png
|
Details | |
10.46 KB,
image/png
|
beltzner
:
ui-review+
beltzner
:
approval1.9+
|
Details |
34.56 KB,
image/png
|
Details | |
24.27 KB,
image/png
|
beltzner
:
ui-review+
beltzner
:
approval1.9+
|
Details |
The Firefox default theme icon, version, and screenshot in Tools->Add-ons->Themes need to be update before the Final Release of 3.0. I know the theme is still a work in progress but I'm filing this just to make sure it doesn't slip through the cracks. Things to change: Theme's icon (We have a different reload button now) Theme's version (Will need to be changed from '2.0' to '3.0') Preview (Will need an updated screenshot of our navigation buttons)
Flags: blocking-firefox3?
Assignee | ||
Comment 1•17 years ago
|
||
We will likely do this as one of the very last things for the new themes.
Updated•17 years ago
|
Assignee: nobody → faaborg
Component: General → Theme
Flags: blocking-firefox3? → blocking-firefox3+
Updated•17 years ago
|
QA Contact: general → theme
Updated•17 years ago
|
Priority: -- → P2
Assignee | ||
Comment 4•17 years ago
|
||
We updated the theme icon and preview image in b5 (now says "beta 5 theme", we will continue to update it in future icon drops). One issue is that we have not been able to use chrome overrides to provide different images for Luna and Aero.
Maybe we change "reload" image to "home" image just like in Firefox 2.0 themes preview? This would be much better choice. Reload image looks so simple, but home button is more complicated and appears to better presents final 3.0 theme. This is only a proposition.
Comment 6•16 years ago
|
||
Alex, ETA on the updated image? Forget chrome overrides for Vista and Luna, the refresh icon looks basically the same for both, so just use the Vista one.
Assignee | ||
Comment 7•16 years ago
|
||
I think we should fall back to the firefox icon, these will be included in the next icon drop. What should we do with the actual theme preview image if we can't match the OS?
Comment 8•16 years ago
|
||
To represent both themes the preview image could be in greyscale, as there are very few differences in shape
Comment 9•16 years ago
|
||
Or, don't preview the theme, just have the wordmark+logo or something. Don't overthink this.
Assignee | ||
Comment 10•16 years ago
|
||
>To represent both themes the preview image could be in greyscale, as there are
>very few differences in shape
Yeah, I was thinking about trying out the disabled states of the core navigation controls with a gray font for the wordmark. If that doesn't look good I'll fall back to the wordmark+logo.
Comment 11•16 years ago
|
||
Alex, we need something today for this.
Comment 12•16 years ago
|
||
Let's get: - a name for the theme - an image we can use across all themes How about these names: - Proto (OSX) - Tango (Linux) - Strata (Windows) For the image, each theme can do what they want as a way of expressing their theme. For Windows, it'll likely be disabled state keyhole so that it looks good on luna and aero.
Comment 13•16 years ago
|
||
Oh, and the font used should be Meta Bold.
Assignee | ||
Comment 14•16 years ago
|
||
OS X and Linux themers: note that we need to recreate the theme preview images to replace the Firefox word mark with platform specific theme names.
Comment 15•16 years ago
|
||
Does it have to be Meta Bold? I'm wondering if we could use Tango's official logo in the preview.
Comment 16•16 years ago
|
||
Well, I'd rather it be Meta Bold, as that ties it together with Firefox without actually using the logo/wordmark, and provides some visual consistency.
Comment 17•16 years ago
|
||
(In reply to comment #12) > How about these names: > - Proto (OSX) > - Tango (Linux) > - Strata (Windows) I know about Proto as a final name for the Mac theme. Here's a suggestion for the theme across all platforms: - Firelight
Comment 18•16 years ago
|
||
Alex and I were actually thinking that we'd want to keep the theme names different, both as a convenient way of talking about them, and a way for the reviewers to talk about how they "love Proto" and "adore Strata" and "think Tango really does look like Linux!" I suppose we could do "Firelight" across all themes, but then you're talking about "Firelight on Linux", "Firelight on Windows", etc, etc.
Assignee | ||
Comment 19•16 years ago
|
||
It will also make it easier for us to track feedback in the blogosphere and twiterverse if use use somewhat unique strings for the theme names. Not that I stay up late at night reading every comment or anything...
Comment 20•16 years ago
|
||
Liar. Ok, well, Firelight for Mac? Proto probably isn't a "final" name. Can we get images for this, and wrap this up today?
Comment 21•16 years ago
|
||
This is just a rough GIMP-up. I haven't had any contact or permission from the Tango project about this (so don't even think about this as final), I just want to know if something like this was what you had in mind. This uses the Tango logo style but with the Meta font instead.
Comment 22•16 years ago
|
||
Comment on attachment 317653 [details]
Proposal? (Linux)
Yup, this is exactly in the vein of what we were thinking.
Attachment #317653 -
Flags: ui-review+
Comment 23•16 years ago
|
||
Has faaborg been in contact with the Tango team regarding this? I haven't been able to, and since this bug hasn't had any status updates for a while, should this still block?
Assignee | ||
Comment 24•16 years ago
|
||
>Has faaborg been in contact with the Tango team regarding this?
No, but everyone should be cc'd to this bug. I'll ping people in private email as well.
Comment 25•16 years ago
|
||
Sadly I don't have the font in question to fix it myself, but there's just something odd about the outline rendering of 'tango!' in michael's image. The stroke feels stronger at places and the even kerning feels off (ta n go).
Assignee | ||
Comment 26•16 years ago
|
||
Here is the theme preview for Strata. Since this image will be used on both XP and Vista, I am going for a very light feel and avoiding the use of any color in the icons. Both the large and small icons are shown to increase discoverability of the existence of small icon mode. The title is at the same level of opacity of the icons, so it will continue to match if placed on a background color that is not white.
Attachment #318352 -
Flags: ui-review?(beltzner)
Assignee | ||
Comment 27•16 years ago
|
||
Here is what the windows theme preview looks like in context.
Comment 28•16 years ago
|
||
Comment on attachment 318352 [details]
Windows theme preview
a=beltzner, and before anyone says it, yes, I'm fine with this being in grey and no it doesn't look disabled.
Attachment #318352 -
Flags: ui-review?(beltzner)
Attachment #318352 -
Flags: ui-review+
Attachment #318352 -
Flags: approval1.9+
Comment 29•16 years ago
|
||
This will not block the final release of Firefox 3. Any patch will need unit tests in order to be approved.
Flags: blocking-firefox3+ → blocking-firefox3-
Updated•16 years ago
|
Flags: blocking-firefox3- → blocking-firefox3+
Whiteboard: [needs status update] → [windows done][osx/linux needed]
Updated•16 years ago
|
Whiteboard: [windows done][osx/linux needed] → [windows done][osx/linux needed][ETA 4/28]
Updated•16 years ago
|
Whiteboard: [windows done][osx/linux needed][ETA 4/28] → [windows done][osx/linux needed][ETA 4/29]
Comment 30•16 years ago
|
||
Updated•16 years ago
|
Attachment #318445 -
Flags: ui-review?(beltzner)
Comment 31•16 years ago
|
||
Comment on attachment 318445 [details]
Tango theme preview
ui-r+a=beltzner
Attachment #318445 -
Flags: ui-review?(beltzner)
Attachment #318445 -
Flags: ui-review+
Attachment #318445 -
Flags: approval1.9+
Updated•16 years ago
|
Keywords: checkin-needed
Comment 32•16 years ago
|
||
Comment on attachment 318445 [details]
Tango theme preview
Ooops. Let's not start the "UN Flag is a no-no" war here. Can we get a different icon in its place?
Attachment #318445 -
Flags: ui-review-
Attachment #318445 -
Flags: ui-review+
Attachment #318445 -
Flags: approval1.9-
Attachment #318445 -
Flags: approval1.9+
Updated•16 years ago
|
Keywords: checkin-needed
Comment 33•16 years ago
|
||
This one has the Themes icon instead of the flag.
Comment 34•16 years ago
|
||
Updated•16 years ago
|
Attachment #318467 -
Flags: ui-review?(beltzner)
Comment 35•16 years ago
|
||
Comment on attachment 318467 [details]
Tango theme preview with Themes icon
uir+a=beltzner, thanks!
Attachment #318467 -
Flags: ui-review?(beltzner)
Attachment #318467 -
Flags: ui-review+
Attachment #318467 -
Flags: approval1.9+
Comment 36•16 years ago
|
||
Comment on attachment 318469 [details]
OS X(Firelight) Theme Preview
uir+a=beltzner
Firelight, eh? Buckin' the trend of monosyllabic, vowel-ending words? ;)
Attachment #318469 -
Flags: ui-review+
Attachment #318469 -
Flags: approval1.9+
Updated•16 years ago
|
Whiteboard: [windows done][osx/linux needed][ETA 4/29] → [all done, need to land][ETA 4/29]
Updated•16 years ago
|
Keywords: checkin-needed
Comment 37•16 years ago
|
||
Actual preview.png for Firelight.
Updated•16 years ago
|
Attachment #318542 -
Flags: ui-review+
Attachment #318542 -
Flags: approval1.9+
Updated•16 years ago
|
Attachment #318469 -
Flags: ui-review+
Attachment #318469 -
Flags: approval1.9+
Updated•16 years ago
|
Attachment #317653 -
Attachment is obsolete: true
Updated•16 years ago
|
Attachment #318445 -
Attachment is obsolete: true
Comment 38•16 years ago
|
||
mozilla/browser/themes/gnomestripe/browser/preview.png 1.6 mozilla/browser/themes/pinstripe/browser/preview.png 1.7 mozilla/browser/themes/winstripe/browser/preview.png 1.6
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [all done, need to land][ETA 4/29]
Target Milestone: --- → Firefox 3
Comment 39•16 years ago
|
||
verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050104 Minefield/3.0pre, Win Vista Nightly, Win XP Nightly, and Linux nightly.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•