414625 - nodoka theme git: checkbuttons and radiobuttons have wrong focus

Status: NEW

(Firefox :: Shell Integration, defect)

Description

[u294409]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b3pre) Gecko/2008012904 Fedora/8 (Werewolf) Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b3pre) Gecko/2008012904 Fedora/8 (Werewolf) Minefield/3.0b3pre

the checkbuttons and radiobuttons have wrong focus indicator.
main button has nothing, label has button's/tab's focus indicator (label's focus looks like native tab or button focus).

of course in preferences. on website, instead of native focus on those kind of buttons is shown focus of the label, but this bug is known (I cannot find the bug now).

Reproducible: Always

Actual Results:  
wrong focus for checkbuttons and radiobuttons in preferences

Expected Results:  
everything ok

Comment 1

[u294409]

Attachment: screenshot of firefox

Comment 2

[u294409]

Attachment: screenshot of the widget factory

Comment 3

[Michael Monreal [:micmon]]

The fancy focus drawing of Clearlooks 2.21.x works nice in most places. How is this supposed to look using Nodoka?

Comment 4

[u294409]

I've posted a screenshot.

Comment 5

[u294409]

Firefox doesn't draw slightly bold checbox, but shadow around label, what is wrong for Nodoka.

Comment 6

[Martin Sourada]

How many times I have to repeat that it's because it is drawn in gtk_draw_focus for Firefox while in native gtk apps it is handled in gtk_draw_box (in nodoka engine)? What seems however wrong is that the focus is not drawn around the label when the checkbutton is placed on webpage. 

Comment 7

[u294409]

I don't want you to repeat youself but to help Mozilla team with fixing it.

Comment 8

[Teune van Steeg]

To do this correctly we need to set the flag GTK_HAS_FOCUS to the check box/radio button widget, which would normally be done by setting state->focused to true. Because of bug 142898 however, we need to draw focus outlines for HTML check boxes/radio buttons, for which we use state->focused. This means if we would set state->focused for check boxes/radio buttons in XUL, we would draw an outline for those widgets as well as for their labels on themes like Clearlooks.

So to fix this issue, either we need to have bug 142898 fixed, so we can implement it properly and remove the current 'draw focus outline for HTML' workaround (which is by far the best solution), or we need to add another workaround to indicate that the focused widget is in XUL and therefore doesn't need a focus outline (which in my opinion is not worth the trouble, since ATM only one GTK Theme is affected and most importantly there still is a focus indication).