414741 - General Preference is highlighted when opening Preferences.

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Eiichi]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en; rv:1.8.1.12pre) Gecko/20080129 Camino/1.6b3pre (like Firefox/2.0.0.12pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en; rv:1.8.1.12pre) Gecko/20080129 Camino/1.6b3pre (like Firefox/2.0.0.12pre)

General Preference is highlighted when opening Preferences except History.
Screenshot is forthcoming.

Reproducible: Always

Comment 1

[Eiichi]

Attachment: Screenshot: Selecting Appearance

Comment 2

[Eiichi]

Attachment: Screenshot: Selecting History

Comment 3

[Eiichi]

I look into this.
20080103 nightly build has no issues. 
This has started since 20080104 nightly build.

Related checked in:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-01-03&maxdate=2008-01-04&cvsroot=%2Fcvsroot

Comment 4

[philippe (part-time)]

I can't reproduce this on 10/5 and 10/4 with trunk builds

Comment 5

[Stuart Morgan]

This would certainly be related to bug 371484. Do you have FKA enabled?

Comment 6

[Eiichi]

(In reply to comment #5)
> This would certainly be related to bug 371484. Do you have FKA enabled?
> 

No, I don't have FKA enabled.

Comment 7

[Mark Mentovai]

I don't see this on Leopard with FKA off, but there aren't really STR here, so I might be missing something.

Maybe add a nil check here:

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/camino/src/preferences/MVPreferencesController.mm&rev=1.32&mark=569#549

Comment 8

[Eiichi]

For reference, I'm using Mac OS X Version 10.4.11 (Intel).

Comment 9

[Stuart Morgan]

(In reply to comment #7)
> Maybe add a nil check here:

At the time (bug 371484), you were of the opinion that that wouldn't be the right behavior; did it cause issues on Leopard?

Comment 10

[Mark Mentovai]

I don't recall that it did - I think my reasoning was more that I trusted our code to take first responder status away from something no longer visible than I trusted AppKit.

Comment 11

[Mark Mentovai]

Attachment: Possible fix

The nil check had no impact, because firstValidKeyView wasn't nil, it was actually set to the toolbar icon's view.

It seems like -[NSView nextValidKeyView] can return something that in fact shouldn't become key view on Tiger.  We should check whatever we get back from it.

I tested a variant of this patch on the tinderbox, but not this patch exactly.  The tinderbox is currently the easiest way for me to test 10.4, and that's not so easy, so I haven't tested this exact patch out on 10.4.  It doesn't regress anything on 10.5.  I'd appreciate if someone who can test on 10.4 more easily can try this.

Comment 12

[Eiichi]

(In reply to comment #11)

> I tested a variant of this patch on the tinderbox, but not this patch exactly. 
> The tinderbox is currently the easiest way for me to test 10.4, and that's not
> so easy, so I haven't tested this exact patch out on 10.4.  It doesn't regress
> anything on 10.5.  I'd appreciate if someone who can test on 10.4 more easily
> can try this.
> 

I applied an attachment (id=300419) and tested on 10.4.11 (Intel).
It works as expected and the issue has been solved.

Comment 13

[Mark Mentovai]

Checked in on the trunk and MOZILLA_1_8_BRANCH before 1.6b3.