414776 - Bookmarking completely broken

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[u88484]

Bookmarking is completely broken in 2008012920 build, not sure if this is the first build that it was broke in though.

starring, ctrl+d, and right-click->bookmark this page have no effect

Ctrl+d results in:

Error: PlacesCommandHook is not defined
Source file: chrome://browser/content/browser.xul
Line: 1


Clicking star results in:

Error: PlacesCommandHook is not defined
Source file: chrome://browser/content/browser.js
Line: 5980


Right-click -> 'Bookmark This Page' results in:

Error: window.top.PlacesCommandHook is undefined
Source file: chrome://browser/content/nsContextMenu.js
Line: 1078

Comment 1

[Al Billings [:abillings - ex-MoCo]]

Works fine in Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2008012804 Minefield/3.0b3pre.

Comment 2

[Al Billings [:abillings - ex-MoCo]]

Looks like it is Windows specific (if not more specific). I just upgraded my Mac build to  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2008012904 Minefield/3.0b3pre and I don't see the problem.

Comment 3

[u88484]

Broken by bug 393509?

Comment 4

[Al Billings [:abillings - ex-MoCo]]

Unlikely. That was only checked in at 8:43 PM, not quite two hours ago. The build was made earlier than that.

Comment 5

[Al Billings [:abillings - ex-MoCo]]

No repro using  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012904 Minefield/3.0b3pre. This works for me. No problems adding bookmarks, no error messages in console. Same on Mac (see above).

Comment 6

[u88484]

Works in 20080129_1924 build
Broken in 20080129_2038 build

Query: http://hourly-archive.localgho.st/win32/20080129_2038_checkins.html

Comment 7

[u88484]

Al, your about 16 hours behind in builds ;)

Comment 8

[pal-moz]

(In reply to comment #5)
> No repro using  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre)
> Gecko/2008012904 Minefield/3.0b3pre. This works for me. No problems adding
> bookmarks, no error messages in console. Same on Mac (see above).
> 

no problem with Nightly (2008012904, you are using)
problem with Hourly, after Nightly.

Comment 9

[Al Billings [:abillings - ex-MoCo]]

Latest daily, which is what QA uses. I believe you though and that's pretty specific.

Comment 10

[hhh]

I can confirm this in both Windows and Linux. Neither the star, bookmarks menu or page context-menu works.

20080129_2220_firefox-3.0b3pre.en-US.linux-i686.tar.bz2   

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008012922 Minefield/3.0b3pre

Comment 11

[Reed Loden [:reed]]

Al, check build ids next time, please, especially when multiple people are seeing a problem.

Comment 12

[Tracy Walker [:tracy]]

Based on comments, this is a smoketest blocker. 

Comment 13

[Asaf Romano (gone)]

Fixed now, checked in the wrong file earlier, sorry.

Comment 14

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv