With Stylish 0.5.3 and Firefox 188.8.131.52 RC1: 1. Click on the Stylish icon, Write Style, For this URL... 2. Preview Result: TypeError: stylesheet has no properties This worked with 184.108.40.206. I'm the author of Stylish and I can make changes to it if required.
Stylish is trying to get a nsIDOMDocumentStyle from a string of CSS text. To do this, it: 1. Creates a document: document.implementation.createDocument(stylishCommon.XULNS, "stylish-parse", null) 2. Appends a link element with a data URI to the document's document element. 3. Gets a stylesheet object out of the document: doc.QueryInterface(Components.interfaces.nsIDOMDocumentStyle).styleSheets 4. Checks to make sure it's done loading. It's expecting stylesheet.cssRules.length to throw NS_ERROR_DOM_INVALID_ACCESS_ERR if it's not done. Instead, 'stylesheet' is undefined.
'stylesheet' never gets defined, even on subsequent checks.
Olli, could this be a regression from bug 393762?
Jason, could you try these two builds? (before/after bug 393762) http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2008-01-22-04-mozilla1.8/ http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2008-01-23-03-mozilla1.8/
2008-01-22-04-mozilla1.8 - Bug not present 2008-01-23-03-mozilla1.8 - Bug present
Any chance to get a minimal testcase, attached using "Add an attachment"
Haven't yet tested, but my guess is that since loading external files from data document (which are now created when .createDocument is used) isn't allowed anymore, loading stylesheets using a data document doesn't work either.
So this is a regression from bug 382636. Do we want to allow loading external files on branch, but perhaps not on trunk? ... I need to still verify that that is the case here.
9 years ago
Created attachment 300432 [details] [diff] [review] revert back the old behavior Do we want to use this? Jonas, bz, anyone? Doesn't regress Bug 393762 or Bug 393761
Created attachment 300438 [details] testcase, works on Opera and Safari too Opera gives the same result as 2.0.11, Safari same as trunk
I thought we already set createDocument() documents to be data documents... If we don't, that seems like a bug. I'm not sure about the security aspect of it, though. If it's safe, it might indeed make sense to revert that part for compat reasons.
No we didn't set .createDocuments as data documents. It is IMO a bug, which is now fixed both on branch (sort of accidentally) and on trunk (on purpose). The extension must be changed for FF3, but during FF2 it is better to not change the behavior unless absolutely needed.
9 years ago
It's not just the extension, the testcase shows this change affects web content. Dunno if anyone uses it, but it's definitely a potentially web-breaking change not just an addon problem.
Comment on attachment 300432 [details] [diff] [review] revert back the old behavior approved for 220.127.116.11, a=dveditz for release-drivers
Jason, could you please try next nightlies. Thanks!
Checked in to GECKO181_20080128_RELBRANCH and MOZILLA_1_8_BRANCH
Please get some mochitests in?
To test the current trunk behavior? Or branch behavior?
I guess trunk. That is IMO what we want, or otherwise we should allow also image loads etc on data documents.
The primary bugs to regression test are of course bug 393762 and bug 393761. This will, of course, regress bug 382636 since this bug is basically about backing that one out. That is expected and OK for the 1.8 branch. Make sure it doesn't regress old bug 325005 (which checks the "loadedAsData" flag).
This is fixed in Mozilla/5.0 (X11; U; Linux i686; en-US; rv:18.104.22.168) Gecko/2008013015 Firefox/22.214.171.124. I've verified it.
9 years ago
Verified FIXED using Bonsai: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=shipped-locales&branch=MOZILLA_1_8_BRANCH&root=/cvsroot&subdir=/mozilla/browser/locales&command=DIFF_FRAMESET&rev1=126.96.36.199&rev2=188.8.131.52 Replacing fixed184.108.40.206 keyword with verified220.127.116.11.
(In reply to comment #23) > Verified FIXED using Bonsai: > > http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=shipped-locales&branch=MOZILLA_1_8_BRANCH&root=/cvsroot&subdir=/mozilla/browser/locales&command=DIFF_FRAMESET&rev1=18.104.22.168&rev2=22.214.171.124 > > Replacing fixed126.96.36.199 keyword with verified188.8.131.52. Commented in the wrong bug, sorry, restoring fixed184.108.40.206 keyword.
This is verified for 220.127.116.11 as well. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:18.104.22.168) Gecko/2008031114 Firefox/22.214.171.124