414935 - [client] Only use Modern theme in testing for Mozilla suite and SeaMonkey 1.x

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Robert Kaiser]

http://mxr.mozilla.org/mozilla/source/tools/tinderbox/build-seamonkey-util.pl#2228 makes us set the "Modern" theme for testing, but that should only be done for Mozilla suite (do we need to still support it at all in tinderbox?) and SeaMonkey 1.x (1.8 branch, no vendor name set).
Other apps than Mozilla suite and SeaMonkey don't include that theme, and SeaMonkey 2 should better test with the default theme.

Comment 1

[Robert Kaiser]

Attachment: make the whole section |if Mozilla/SeaMonkey 1.x|

Here's a patch that only executes that whole section for Mozilla suite and SeaMonkey 1.x (AFAIK).

Comment 2

[Wolf [:wolf]]

I wouldn't think tinderbox client needs MAS support anymore.. the 1.7 branch is
long dead now.

Comment 3

[Robert Kaiser]

if coop thinks we should stop supporting Mozilla suite and requests leaving out the "Mozilla" part there, the if is easy to shorten to use the second part only that checks for SeaMonkey 1.x

Comment 4

[Tony Mechelynck [:tonymec]]

IIUC, this bug is now preventing Sm-trunk nightlies for Linux from being produced, see bug 414877. If this is true I move the severity of this bug be raised.

Comment 5

[Chris Cooper [:coop] (he/him)]

Comment on attachment 300458 [details] [diff] [review]
make the whole section |if Mozilla/SeaMonkey 1.x|

No reason to remove the Suite code at this time, so might as well leave it in.

Comment 6

[Robert Kaiser]

Thanks, checked in. Apart from being the correct thing to do, it should fix the current SeaMonkey orange, see comment #4 - I'll be watching all tinderboxen carefully in the next hours.