414958 - Move talos utils output to python logger.

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect, P2)

Description

[Mikeal Rogers [:mikeal] (mrogers@)]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2008012804 Minefield/3.0b3pre
Build Identifier: 

The talos utils module does a bunch of output masking and timestamping that could all be replaced using the standard python logging module and would make it more efficient/standardized.



Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Mikeal Rogers [:mikeal] (mrogers@)]

Attachment: logging patch 1

Patch to replace utils output functionality with python logging module.

Comment 2

[Mikeal Rogers [:mikeal] (mrogers@)]

Attachment: Logging patch 2

Comment 3

[Mikeal Rogers [:mikeal] (mrogers@)]

Attachment: Logging patch 3

Comment 4

[Mikeal Rogers [:mikeal] (mrogers@)]

Attachment: Logging patch 4

Comment 5

[alice nodelman [:alice] [:anode]]

Comment on attachment 301326 [details] [diff] [review]
Logging patch 4

     ffprocess.Sleep()
     #set up the counters for this test
     cm = CounterManager("firefox", counters)
+    cm.setDaemon(1)
     cm.startMonitor()
     counter_results = {}

setDaemon breaks talos on windows machines, raises an AttributeError.

Comment 6

[Mikeal Rogers [:mikeal] (mrogers@)]

Attachment: Logging patch 5

Fixing windows failure.

Sets better spacing minimums on log output for better alignment.

Comment 7

[alice nodelman [:alice] [:anode]]

Comment on attachment 301608 [details] [diff] [review]
Logging patch 5

Raised the following error after a run of tsvg (with --debug --noisy).

Traceback (most recent call last):
  File "c:\Python25\lib\logging\__init__.py", line 744, in emit
    msg = self.format(record)
  File "c:\Python25\lib\logging\__init__.py", line 630, in format
    return fmt.format(record)
  File "c:\Python25\lib\logging\__init__.py", line 418, in format
    record.message = record.getMessage()
  File "c:\Python25\lib\logging\__init__.py", line 288, in getMessage
    msg = msg % self.args
TypeError: not all arguments converted during string formatting

This didn't crash anything but I'd rather it not show up with any frequency in the logs.

Comment 8

[Mikeal Rogers [:mikeal] (mrogers@)]

This is currently on the back burner.

Comment 9

[Mikeal Rogers [:mikeal] (mrogers@)]

Alice, do we plan on taking this at any time?

Since any change, regardless of how minor, seem to screw the numbers a bit is this worth the risk?

If not we should just resolve as invalid.

Comment 10

[alice nodelman [:alice] [:anode]]

This is blocked on comment #7.  I'm not worried about hurting the numbers, more that we don't currently have a patch posted here that works cleanly.

Comment 11

[Mikeal Rogers [:mikeal] (mrogers@)]

Wow, a whole lot has changed since that last patch was generated.

Not only does the patch fail to apply in any way, but my local copy of these changes couldn't be brought up to date via cvs up.

At this point, this would have to be completely re-written from scratch and all we would really get out of it is a slightly different logging format than we have now.

Comment 12

[alice nodelman [:alice] [:anode]]

Sounds like this is at an impasse.  I'm going to mark wontfix since we do currently have a logging strategy that works - even if it doesn't happen to be the most pretty solution.

We can re-open if a patch becomes workable.