Closed
Bug 414958
Opened 15 years ago
Closed 15 years ago
Move talos utils output to python logger.
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: mikeal, Assigned: mikeal)
References
Details
Attachments
(1 file, 4 obsolete files)
15.39 KB,
patch
|
anodelman
:
review-
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2008012804 Minefield/3.0b3pre Build Identifier: The talos utils module does a bunch of output masking and timestamping that could all be replaced using the standard python logging module and would make it more efficient/standardized. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Assignee | ||
Comment 1•15 years ago
|
||
Patch to replace utils output functionality with python logging module.
Attachment #300487 -
Flags: review?(anodelman)
Assignee | ||
Comment 2•15 years ago
|
||
Assignee | ||
Comment 3•15 years ago
|
||
Attachment #300487 -
Attachment is obsolete: true
Attachment #301307 -
Attachment is obsolete: true
Attachment #300487 -
Flags: review?(anodelman)
Assignee | ||
Comment 4•15 years ago
|
||
Attachment #301318 -
Attachment is obsolete: true
Comment 5•15 years ago
|
||
Comment on attachment 301326 [details] [diff] [review] Logging patch 4 ffprocess.Sleep() #set up the counters for this test cm = CounterManager("firefox", counters) + cm.setDaemon(1) cm.startMonitor() counter_results = {} setDaemon breaks talos on windows machines, raises an AttributeError.
Attachment #301326 -
Flags: review-
Assignee | ||
Comment 6•15 years ago
|
||
Fixing windows failure. Sets better spacing minimums on log output for better alignment.
Attachment #301326 -
Attachment is obsolete: true
Attachment #301608 -
Flags: review?(anodelman)
Comment 7•15 years ago
|
||
Comment on attachment 301608 [details] [diff] [review] Logging patch 5 Raised the following error after a run of tsvg (with --debug --noisy). Traceback (most recent call last): File "c:\Python25\lib\logging\__init__.py", line 744, in emit msg = self.format(record) File "c:\Python25\lib\logging\__init__.py", line 630, in format return fmt.format(record) File "c:\Python25\lib\logging\__init__.py", line 418, in format record.message = record.getMessage() File "c:\Python25\lib\logging\__init__.py", line 288, in getMessage msg = msg % self.args TypeError: not all arguments converted during string formatting This didn't crash anything but I'd rather it not show up with any frequency in the logs.
Attachment #301608 -
Flags: review?(anodelman) → review-
Updated•15 years ago
|
Assignee: nobody → mrogers
Updated•15 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Mac OS X → All
Assignee | ||
Comment 9•15 years ago
|
||
Alice, do we plan on taking this at any time? Since any change, regardless of how minor, seem to screw the numbers a bit is this worth the risk? If not we should just resolve as invalid.
Comment 10•15 years ago
|
||
This is blocked on comment #7. I'm not worried about hurting the numbers, more that we don't currently have a patch posted here that works cleanly.
Updated•15 years ago
|
Component: Testing → Release Engineering: Talos
Product: Core → mozilla.org
Version: unspecified → other
Updated•15 years ago
|
Assignee: mrogers → nobody
Status: ASSIGNED → NEW
Priority: P3 → P2
QA Contact: testing → release
Updated•15 years ago
|
Assignee: nobody → mrogers
Assignee | ||
Comment 11•15 years ago
|
||
Wow, a whole lot has changed since that last patch was generated. Not only does the patch fail to apply in any way, but my local copy of these changes couldn't be brought up to date via cvs up. At this point, this would have to be completely re-written from scratch and all we would really get out of it is a slightly different logging format than we have now.
Comment 12•15 years ago
|
||
Sounds like this is at an impasse. I'm going to mark wontfix since we do currently have a logging strategy that works - even if it doesn't happen to be the most pretty solution. We can re-open if a patch becomes workable.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WONTFIX
Updated•10 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•