Last Comment Bug 415007 - PK11_FindCertFromDERSubjectAndNickname is dead code
: PK11_FindCertFromDERSubjectAndNickname is dead code
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.11.9
: All All
P3 normal (vote)
: 3.12
Assigned To: Julien Pierre
Depends on:
  Show dependency treegraph
Reported: 2008-01-30 18:13 PST by Julien Pierre
Modified: 2008-02-05 16:32 PST (History)
0 users
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Remove dead code (2.48 KB, patch)
2008-01-30 18:14 PST, Julien Pierre
rrelyea: review+
Details | Diff | Splinter Review

Description User image Julien Pierre 2008-01-30 18:13:43 PST
Patch forthcoming.
Comment 1 User image Julien Pierre 2008-01-30 18:14:20 PST
Created attachment 300564 [details] [diff] [review]
Remove dead code
Comment 2 User image Nelson Bolyard (seldom reads bugmail) 2008-01-30 20:33:03 PST
Isn't it too late for 3.11.9, which is now in freeze?
If we're going to unfreeze NSS_3_11_BRANCH for this fix, then IMO we 
should also unfreeze NSPR trunk for bug 414997.
Comment 3 User image Julien Pierre 2008-01-31 13:53:17 PST

Yes, it is too late for 3.11.9. Note that I set the target for this to 3.12, not 3.11.9 , and I only asked for one review.
Comment 4 User image Robert Relyea 2008-02-05 16:30:46 PST
Comment on attachment 300564 [details] [diff] [review]
Remove dead code

r+ rrelyea.
Comment 5 User image Julien Pierre 2008-02-05 16:32:49 PST
Thanks, Bob !

I checked this in to the trunk.

Checking in pk11cert.c;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11cert.c,v  <--  pk11cert.c
new revision: 1.163; previous revision: 1.162
Checking in pk11priv.h;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11priv.h,v  <--  pk11priv.h
new revision: 1.8; previous revision: 1.7

Note You need to log in before you can comment on or make changes to this bug.