Closed Bug 415081 Opened 13 years ago Closed 13 years ago

Get rid of lightning-wcap.xpi

Categories

(Calendar :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dbo, Assigned: dbo)

Details

Attachments

(1 file)

This patch removes lightning-wcap.xpi:
- enables WCAP provider being visible in calendar creation wizard
- adds prototype invitation link (only visible if a WCAP calendar is configured)
- removes lightning-wcap.xpi
- removes wcap-enabler.xpi
- removes the above from tinder-config.pl (branch only here)

Reasons:
- It makes releasing 0.8 easier, because only one xpi left.
- It avoids further work for bug 406441.
- There are only little differences left between lightning-wcap.xpi and lightning.xpi left after the prototype event dialog has been promoted official.
- There's large interest in wcap as well as gdata; so we are heading to include both providers either way into lightning.xpi for 0.9 (however wcap will be outsourced into an own extension by then).
Flags: wanted-calendar0.8+
Attached patch patchSplinter Review
Assignee: nobody → daniel.boelzle
Status: NEW → ASSIGNED
Attachment #300645 - Flags: review?(philipp)
Comment on attachment 300645 [details] [diff] [review]
patch

> document.addEventListener("load", ltnOnLoad, true);
>+
No need for empty line

>var sideBarOperationListener = {
Is "sideBar" a fitting name? Just from looking at the code its not quite clear to me what this sidebar is. I realize you just moved this from the other file, but it would be great if it had a more fitting name.

>-<!DOCTYPE overlay SYSTEM "chrome://lightning/locale/sun-lightning.dtd">
This file contains only one entity, we should file a followup bug to move this string after 0.8, or go ahead and do this in case we have late l10n patches. Please file a bug.

r=philipp
Attachment #300645 - Flags: review?(philipp) → review+
(In reply to comment #2)
> >-<!DOCTYPE overlay SYSTEM "chrome://lightning/locale/sun-lightning.dtd">
> This file contains only one entity, we should file a followup bug to move this
> string after 0.8, or go ahead and do this in case we have late l10n patches.
> Please file a bug.

This change would not be fit for a late-l10n change. Such cleanup work is best be done immediately after the 0.8 release.
Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Checked in latest nightly lightning and sunbird builds (20080204), all operating systems -> task is fixed and verified.
Status: RESOLVED → VERIFIED
(In reply to comment #5)
I've done that.
You need to log in before you can comment on or make changes to this bug.