Removing Bookmark from Add Bookmarks dialog, "Bookmark removed" prompt not accessible, focus goes to undefined place.

VERIFIED FIXED in Firefox 3 beta4



Bookmarks & History
10 years ago
8 years ago


(Reporter: MarcoZ, Assigned: surkov)



Firefox 3 beta4
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)



(1 attachment)



10 years ago
1. Go to a page that you know you have bookmarked.
2. Press CTRL+D. The new Add Bookmarks dialog offers a Remove button.
3. Activate that Remove button.
Result: Focus goes to an undefined place, the prompt that says "Bookmark removed" is not accessible.
Expected: Focus should go to a defineed place. Since everything but the Undo button is grayed out, the Undo button should get focus. In addition, the prompt that says "Bookmark removed" should be accessible.
Flags: blocking-firefox3?
The panel itself is focus (we call focus() on the panel element, pressing tab at that point goes to the undo button. We need to focus the panel so ESC close it, but we shouldn't focus the undo button so pressing enter does not revert the changes.

Comment 2

10 years ago
Mano, OK, if the panel is focused, then we need to make sure its accessible name gets updated to reflect the new situation. Right now, it is still called "Add Bookmarks".
Can you set labelledby to the title element within the panel?

Comment 4

10 years ago
(In reply to comment #3)
> Can you set labelledby to the title element within the panel?

If the title has an id attribute, yes!

Comment 5

10 years ago
Created attachment 301012 [details] [diff] [review]
Attachment #301012 - Flags: review?(marco.zehe)

Comment 6

10 years ago
Comment on attachment 301012 [details] [diff] [review]

the attribute is called aria-labelledby. With that fixed, r=me.
Attachment #301012 - Flags: review?(marco.zehe) → review+

Comment 7

10 years ago
Question: This changes the panel#s accessible name from "Bookmark this page" to "Page bookmarked". The latter is what is actually displayed. Aaron, where did you get the "Bookmark this page" prompt from? is this displayed anywhere, or did you introduce that just for accessibility? If the latter, that entity could be removed, since it's no longer needed.

Comment 8

10 years ago
Marco, I was reusing an entity that was already used elsewhere.

Comment 9

10 years ago
OK! This patch fixes the problem, no other action is needed then, I think. Thanks Surkov!
Comment on attachment 301012 [details] [diff] [review]

Attachment #301012 - Flags: approval1.9b3? → approval1.9b3+
Assignee: nobody → surkov.alexander

Comment 12

10 years ago
checked in
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 13

10 years ago
Verified using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3


10 years ago
Flags: blocking-firefox3? → blocking-firefox3+
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.